From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id D5587385782F for ; Fri, 29 Jul 2022 09:48:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D5587385782F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,201,1654588800"; d="diff'?scan'208";a="80370862" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 29 Jul 2022 01:48:14 -0800 IronPort-SDR: VBZT6TMqqwqcVaaGe9LJ+J1RFzeY/3L1w9lmlBHVvoasQdOs9sAug51Ux8RIG7GNGBVcvO5Zwx lTKUzf+z+GFDvoNjKHEE+mW/UmUaQZunTQ8Lk/KeTUp6x5zGg2xd12LmWf2Ol0thYai14DfkUf cGxdhSIhBSMMJW7QsPijJBa5MABzLYkuDFL9c0U5ml6IkUGcIaQsOu97R2QopYdpIXaKpWoIsE 900bGlgEOk3Y/x+R0KqUhw5cI1yxCpvS/C1CkY34MCjz9mAiSCEPrOLCJEPHd7Rv9JFkk6PabH KBE= Content-Type: multipart/mixed; boundary="------------hmQgNkVk7kyDEsMVUkFwqQAO" Message-ID: <21e39473-5bcc-02a0-fc64-564e0a606ac2@codesourcery.com> Date: Fri, 29 Jul 2022 11:48:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [Patch] Add libgomp.c-c++-common/pr106449-2.c (was: [committed] openmp: Fix up handling of non-rectangular simd loops with pointer type iterators [PR106449]) Content-Language: en-US To: Jakub Jelinek , References: From: Tobias Burnus In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2022 09:48:16 -0000 --------------hmQgNkVk7kyDEsMVUkFwqQAO Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 29.07.22 10:03, Jakub Jelinek wrote: > There were 2 issues visible on this new testcase, one that we didn't have > special POINTER_TYPE_P handling in a few spots of expand_omp_simd ... > The other issue was that we put n2 expression directly into a > comparison in a condition and regimplified that, for the &a[512] case tha= t > and with gimplification being destructed that unfortunately meant modific= ation > of original fd->loops[?].n2. Fixed by unsharing the expression. I created a testcase for the non-simd case =E2=80=93 and due to messing up,= it failed; hence, I filled PR middle-end/106467. After fixing the testcase, it passes= . (=E2=86=92 closed PR as invalid). However, given that the testcase now exists, I think it makes sense to add = it :-) Changes compared to the simd testcase: replaced '(parallel for) simd' by 'f= or', removed 'linear', used now 'b' and 'c' instead of storing both ptrs in 'b'. Side remark: Before GCC 12, GCC complained about "q =3D p + n" with "error: initializer expression refers to iteration variable =E2=80=98p=E2= =80=99". OK for mainline? Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------hmQgNkVk7kyDEsMVUkFwqQAO Content-Type: text/x-patch; charset="UTF-8"; name="ptr-for-test.diff" Content-Disposition: attachment; filename="ptr-for-test.diff" Content-Transfer-Encoding: base64 QWRkIGxpYmdvbXAuYy1jKystY29tbW9uL3ByMTA2NDQ5LTIuYwoKVGhpcyBydW4tdGltZSB0 ZXN0IHRlc3QgcG9pbnRlci1iYXNlZCBpdGVyYXRpb24gd2l0aCBjb2xsYXBzZSwKc2ltaWxh ciB0byB0aGUgJyhwYXJhbGxlbCkgc2ltZCcgdGVzdCBmb3IgUFIxMDY0NDkgYnV0IGZvciAn Zm9yJy4KCmxpYmdvbXAvQ2hhbmdlTG9nOgoKCSogdGVzdHN1aXRlL2xpYmdvbXAuYy1jKyst Y29tbW9uL3ByMTA2NDQ5LTIuYzogTmV3IHRlc3QuCgogLi4uL3Rlc3RzdWl0ZS9saWJnb21w LmMtYysrLWNvbW1vbi9wcjEwNjQ0OS0yLmMgICAgfCA2NCArKysrKysrKysrKysrKysrKysr KysrCiAxIGZpbGUgY2hhbmdlZCwgNjQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xp YmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy1jKystY29tbW9uL3ByMTA2NDQ5LTIuYyBiL2xp YmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy1jKystY29tbW9uL3ByMTA2NDQ5LTIuYwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uN2ZlZjc0NjFiY2YKLS0tIC9k ZXYvbnVsbAorKysgYi9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmMtYysrLWNvbW1vbi9w cjEwNjQ0OS0yLmMKQEAgLTAsMCArMSw2NCBAQAorLyogeyBkZy1kbyBydW4gfSAqLworCisv KiBCYXNlZCBvbiBwcjEwNjQ0OS5jIC0gYnV0IHVzaW5nICdmb3InIGluc3RlYWQgb2YgJ3Np bWQnLgorICAgQ2YuIFBSIG1pZGRsZS1lbmQvMTA2NDQ5IChmb3IgcHIxMDY0NDkuYykgYW5k IFBSIG1pZGRsZS1lbmQvMTA2NDY3LiAgKi8KKwordm9pZAorZm9vICh2b2lkKQoreworICBp bnQgYVsxMDI0XSwgKmJbNjU1MzZdLCAqY1s2NTUzNl07CisgIGludCAqcCwgKnEsICoqciA9 ICZiWzBdLCAqKnIyID0gJmNbMF0sIGk7CisgICNwcmFnbWEgb21wIGZvciBjb2xsYXBzZSgy KQorICBmb3IgKHAgPSAmYVswXTsgcCA8ICZhWzUxMl07IHArKykKKyAgICBmb3IgKHEgPSBw ICsgNjQ7IHEgPCBwICsgMTI4OyBxKyspCisgICAgICB7CisJKnIrKyA9IHA7CisJKnIyKysg PSBxOworICAgICAgfQorICBmb3IgKGkgPSAwOyBpIDwgMzI3Njg7IGkrKykKKyAgICBpZiAo YltpXSAhPSAmYVtpIC8gNjRdIHx8IGNbaV0gIT0gJmFbKGkgLyA2NCkgKyA2NCArIChpICUg NjQpXSkKKyAgICAgIF9fYnVpbHRpbl9hYm9ydCAoKTsKK30KKwordm9pZAorYmFyIChpbnQg biwgaW50IG0pCit7CisgIGludCBhWzEwMjRdLCAqYlszMjc2OF0sICpjWzMyNzY4XTsKKyAg aW50ICpwLCAqcSwgKipyID0gJmJbMF0sICoqcjIgPSAmY1swXSwgaTsKKyAgI3ByYWdtYSBv bXAgZm9yIGNvbGxhcHNlKDIpCisgIGZvciAocCA9ICZhWzBdOyBwIDwgJmFbNTEyXTsgcCsr KQorICAgIGZvciAocSA9IHAgKyBuOyBxIDwgcCArIG07IHErKykKKyAgICAgIHsKKwkqcisr ID0gcDsKKwkqcjIrKyA9IHE7CisgICAgICB9CisgIGZvciAoaSA9IDA7IGkgPCAzMjc2ODsg aSsrKQorICAgIGlmIChiW2ldICE9ICZhW2kgLyA2NF0gfHwgY1tpXSAhPSAmYVsoaSAvIDY0 KSArIDY0ICsgKGkgJSA2NCldKQorICAgICAgX19idWlsdGluX2Fib3J0ICgpOworfQorCit2 b2lkCitiYXogKGludCBuLCBpbnQgbSkKK3sKKyAgaW50IGFbMTAyNF0sICpiWzgxOTJdLCAq Y1s4MTkyXTsKKyAgaW50ICpwLCAqcSwgKipyID0gJmJbMF0sICoqcjIgPSAmY1swXSwgaTsK KyAgI3ByYWdtYSBvbXAgZm9yIGNvbGxhcHNlKDIpCisgIGZvciAocCA9ICZhWzBdOyBwIDwg JmFbNTEyXTsgcCArPSA0KQorICAgIGZvciAocSA9IHAgKyBuOyBxIDwgcCArIG07IHEgKz0g MikKKyAgICAgIHsKKwkqcisrID0gcDsKKwkqcjIrKyA9IHE7CisgICAgICB9CisgIGZvciAo aSA9IDA7IGkgPCA0MDk2OyBpKyspCisgICAgaWYgKGJbaV0gIT0gJmFbKGkgLyAzMikgKiA0 XSB8fCBjW2ldICE9ICZhWyhpIC8gMzIpICogNCArIDY0ICsgKGkgJSAzMikgKiAyXSkKKyAg ICAgIF9fYnVpbHRpbl9hYm9ydCAoKTsKK30KKworaW50CittYWluICgpCit7CisgIGZvbyAo KTsKKyAgYmFyICg2NCwgMTI4KTsKKyAgYmF6ICg2NCwgMTI4KTsKKyAgcmV0dXJuIDA7Cit9 Cg== --------------hmQgNkVk7kyDEsMVUkFwqQAO--