From: Jeff Law <law@redhat.com>
To: Alexandre Oliva <oliva@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: add alignment to enable store merging in strict-alignment targets
Date: Tue, 5 Jan 2021 10:16:19 -0700 [thread overview]
Message-ID: <21fc71a7-dc20-ba7a-1214-cedd120a6dd5@redhat.com> (raw)
In-Reply-To: <orft3f7rms.fsf@lxoliva.fsfla.org>
On 1/5/21 12:46 AM, Alexandre Oliva wrote:
> In g++.dg/opt/store-merging-2.C, the natural alignment of types T and
> S is a single byte, so we shouldn't expect store merging on
> strict-alignment platforms. Indeed, without something like the
> adjust-alignment pass to bump up the alignment of the automatic
> variable, as in GCC 10, the optimization does not occur.
>
> This patch adjusts the test so that the required alignment is
> expressly stated, and so we don't rely on its accidentally being there
> to get the desired optimization.
>
> Regstrapped on x86_64-linux-gnu, also tested on x-arm-wrs-vxworks7r2.
> Ok to install?
>
>
> for gcc/testsuite/ChangeLog
>
> * g++.dg/opt/store-merging-2.C: Add the required alignment.
OK
jeff
prev parent reply other threads:[~2021-01-05 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 7:46 Alexandre Oliva
2021-01-05 17:16 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21fc71a7-dc20-ba7a-1214-cedd120a6dd5@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).