From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 52DB33858D33 for ; Thu, 18 Jan 2024 07:19:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 52DB33858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 52DB33858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705562373; cv=none; b=MqgMOR6WJOc2DMxc7pJTdN5Pc+AJoPyyb4ym4bhs2fZXnPCVmfZcyWIEpTMgQJKOldJB35alUywGv31SR1hMRoTzKxNoaMs0UB6MKP46VWxjBWSwaXI3Nt5CWRxAbexfYtmwLGmabmBrBhAITS++xCzKG+SJWC5w7qP1DVNtIZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705562373; c=relaxed/simple; bh=TKX0hg6x5v2gFHo75w/9D5hQfuNe0pP9+XcZD+zLlPQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=Osgv9Zoci8N93OSGoeQunZ/x8f5Kr7IsylPKB7zlFXKiwbrRQFaHyMM20uU7ufWznJPbbbKh2OPjZVbL6oUf5DnzuHBtE+Z2G1y7/mdTvZMCIJ4xIuWNW+1ROBjz8NyPR7FIVWXxefY389E8M12kAlSZuWteec/0NCSczHGtoW0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E00FE2228B; Thu, 18 Jan 2024 07:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705562371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MZxWS+pc0Da+4dFhVPfbBiOpUnV2Z4leLuGTOIA/S2Q=; b=LE6VsbQg8nP2IgjP9gEm44cr2et5GvLofUIUeCPNOsP7t+MiVw2jts+Kptp/AUEXp8zSPg Hp3A1kmH0L9P6E8Vna5gN2MurxWKRfUWmWmRDlN37FEDKcfDqnGNFe98Toi2oT5k6jSqYU T6Ki+c9stuxaxX1+1WOY5Ree9SYqafQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705562371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MZxWS+pc0Da+4dFhVPfbBiOpUnV2Z4leLuGTOIA/S2Q=; b=ykiaG4AsjlvnQB36lVN9Qj5T9WBHIC8DLepVzENCjJxVs6RCOZY6fk+ohL7zmze60lq6Ud dpHnUJ9uNFeeKtDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705562370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MZxWS+pc0Da+4dFhVPfbBiOpUnV2Z4leLuGTOIA/S2Q=; b=uqVi5pCEWQT7sW4QBbE1wqtcD8AWwIdG1XtL54/uFD76OcdhJDmn4gj2EmeJWxk6BBrKUN liDDFNYWXYsjuzkdp7zvWzkPTEc9Ct9vsaK8Pxr1qV/bp5TY3FeKiJOTZqdMFgBSE/vzUh k4N3zdkLuz4ckvVN0zHY4NLYNnM4XZk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705562370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MZxWS+pc0Da+4dFhVPfbBiOpUnV2Z4leLuGTOIA/S2Q=; b=tmMUHOq60QneJEc2XjyyPoSvtlZUySMPwtnOsBmmdTCTDb1MtbEhtICkf8LUvYr7ZKG6xC VbdBl3F9SDm24pCA== Date: Thu, 18 Jan 2024 08:14:22 +0100 (CET) From: Richard Biener To: Martin Jambor cc: GCC Patches Subject: Re: [PATCH] sra: Disqualify bases of operands of asm gotos In-Reply-To: Message-ID: <21nn1249-80rr-03o3-r307-5415r6qq6o51@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-7.10 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: X-Spam-Score: -7.10 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 17 Jan 2024, Martin Jambor wrote: > Hi, > > PR 110422 shows that SRA can ICE assuming there is a single edge > outgoing from a block terminated with an asm goto. We need that for > BB-terminating statements so that any adjustments they make to the > aggregates can be copied over to their replacements. Because we can't > have that after ASM gotos, we need to punt. > > Bootstrapped and tested on x86_64-linux, OK for master? It will need > some tweaking for release branches, is it in principle OK for them too > (after testing)? OK. > Thanks, > > Martin > > > gcc/ChangeLog: > > 2024-01-17 Martin Jambor > > PR tree-optimization/110422 > * tree-sra.cc (scan_function): Disqualify bases of operands of asm > gotos. > > gcc/testsuite/ChangeLog: > > 2024-01-17 Martin Jambor > > PR tree-optimization/110422 > * gcc.dg/torture/pr110422.c: New test. > --- > gcc/testsuite/gcc.dg/torture/pr110422.c | 10 +++++++++ > gcc/tree-sra.cc | 29 ++++++++++++++++++++----- > 2 files changed, 33 insertions(+), 6 deletions(-) > create mode 100644 gcc/testsuite/gcc.dg/torture/pr110422.c > > diff --git a/gcc/testsuite/gcc.dg/torture/pr110422.c b/gcc/testsuite/gcc.dg/torture/pr110422.c > new file mode 100644 > index 00000000000..2e171a7a19e > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/torture/pr110422.c > @@ -0,0 +1,10 @@ > +/* { dg-do compile } */ > + > +struct T { int x; }; > +int foo(void) { > + struct T v; > + asm goto("" : "+r"(v.x) : : : lab); > + return 0; > +lab: > + return -5; > +} > diff --git a/gcc/tree-sra.cc b/gcc/tree-sra.cc > index 6a1141b7377..f8e71ec48b9 100644 > --- a/gcc/tree-sra.cc > +++ b/gcc/tree-sra.cc > @@ -1559,15 +1559,32 @@ scan_function (void) > case GIMPLE_ASM: > { > gasm *asm_stmt = as_a (stmt); > - for (i = 0; i < gimple_asm_ninputs (asm_stmt); i++) > + if (stmt_ends_bb_p (asm_stmt) > + && !single_succ_p (gimple_bb (asm_stmt))) > { > - t = TREE_VALUE (gimple_asm_input_op (asm_stmt, i)); > - ret |= build_access_from_expr (t, asm_stmt, false); > + for (i = 0; i < gimple_asm_ninputs (asm_stmt); i++) > + { > + t = TREE_VALUE (gimple_asm_input_op (asm_stmt, i)); > + disqualify_base_of_expr (t, "OP of asm goto."); > + } > + for (i = 0; i < gimple_asm_noutputs (asm_stmt); i++) > + { > + t = TREE_VALUE (gimple_asm_output_op (asm_stmt, i)); > + disqualify_base_of_expr (t, "OP of asm goto."); > + } > } > - for (i = 0; i < gimple_asm_noutputs (asm_stmt); i++) > + else > { > - t = TREE_VALUE (gimple_asm_output_op (asm_stmt, i)); > - ret |= build_access_from_expr (t, asm_stmt, true); > + for (i = 0; i < gimple_asm_ninputs (asm_stmt); i++) > + { > + t = TREE_VALUE (gimple_asm_input_op (asm_stmt, i)); > + ret |= build_access_from_expr (t, asm_stmt, false); > + } > + for (i = 0; i < gimple_asm_noutputs (asm_stmt); i++) > + { > + t = TREE_VALUE (gimple_asm_output_op (asm_stmt, i)); > + ret |= build_access_from_expr (t, asm_stmt, true); > + } > } > } > break; > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)