From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Jiufu Guo <guojiufu@linux.ibm.com>
Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org,
bergner@linux.ibm.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] rs6000, testcase: Add require-effective-target has_arch_ppc64 to pr106550_1.c
Date: Tue, 7 Nov 2023 10:27:24 +0800 [thread overview]
Message-ID: <22011075-dbb5-7d1e-64c4-1e0a4b2cb3c6@linux.ibm.com> (raw)
In-Reply-To: <20231106072004.3002543-1-guojiufu@linux.ibm.com>
Hi,
on 2023/11/6 15:20, Jiufu Guo wrote:
> Hi,
>
> With latest trunk, case pr106550_1.c can run with failure on ppc under -m32.
> While, the case is testing 64bit constant building. So, "has_arch_ppc64"
> is required.
Please also mention that it failed with ICE initially due to PR111971, now
that PR got fixed so this omission is exposed.
>
> Test pass on ppc64{,le}.
>
> BR,
> Jeff (Jiufu Guo)
>
> gcc/testsuite/ChangeLog:
>
There is PR112340, need a corresponding PR marker line.
OK for trunk with these nits tweaked, thanks!
BR,
Kewen
> * gcc.target/powerpc/pr106550_1.c: Add has_arch_ppc64 target require.
>
> ---
> gcc/testsuite/gcc.target/powerpc/pr106550_1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550_1.c b/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
> index 7e709fcf9d8..5ab40d71a56 100644
> --- a/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
> @@ -1,5 +1,6 @@
> /* PR target/106550 */
> /* { dg-require-effective-target power10_ok } */
> +/* { dg-require-effective-target has_arch_ppc64 } */
> /* { dg-options "-O2 -mdejagnu-cpu=power10 -fdisable-rtl-split1" } */
> /* force the constant splitter run after RA: -fdisable-rtl-split1. */
>
next prev parent reply other threads:[~2023-11-07 2:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 7:20 [PATCH] rs6000,testcase: " Jiufu Guo
2023-11-07 2:27 ` Kewen.Lin [this message]
2023-11-07 9:36 ` [PATCH] rs6000, testcase: " Jiufu Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22011075-dbb5-7d1e-64c4-1e0a4b2cb3c6@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guojiufu@linux.ibm.com \
--cc=linkw@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).