gcc git hook

gcc git hook

[Nathan Sidwell]

Is it possible for the git hooks to reject pushes with overly-long 
subject lines?

I occasionally see pushes that forgot to add a separate title line, and 
so the whole of the commit description gets used.

nathan
-- 
Nathan Sidwell

Re: gcc git hook

[Joseph Myers]

On Thu, 10 Sep 2020, Nathan Sidwell wrote:

> Is it possible for the git hooks to reject pushes with overly-long subject
> lines?
> 
> I occasionally see pushes that forgot to add a separate title line, and so the
> whole of the commit description gets used.

Is that where the whole description is a single long unwrapped line?  
(The case of no blank line after the first line - a message starting with 
a multi-line paragraph - should already be diagnosed.)

We've disabled the check on lengths of lines in commit messages:

        # We do not want to force a maximum line length in commit
        # revision logs, as they get in the way of copy-pasting
        # debugging session, error messages, logs, etc.
        max-rh-line-length = 0

But we could add a local check in our commit_checker script for just the 
length of the first line (alongside the checks for a first line that looks 
like a ChangeLog header or is just a single word).

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: gcc git hook

[Nathan Sidwell]

On 9/10/20 1:21 PM, Joseph Myers wrote:
> On Thu, 10 Sep 2020, Nathan Sidwell wrote:
> 
>> Is it possible for the git hooks to reject pushes with overly-long subject
>> lines?
>>
>> I occasionally see pushes that forgot to add a separate title line, and so the
>> whole of the commit description gets used.
> 
> Is that where the whole description is a single long unwrapped line?
> (The case of no blank line after the first line - a message starting with
> a multi-line paragraph - should already be diagnosed.)

the most recent is ad2a37157d3, where it is indeed as you say.  I know 
I've done it in too.

> 
> We've disabled the check on lengths of lines in commit messages:
> 
>          # We do not want to force a maximum line length in commit
>          # revision logs, as they get in the way of copy-pasting
>          # debugging session, error messages, logs, etc.
>          max-rh-line-length = 0
> 
> But we could add a local check in our commit_checker script for just the
> length of the first line (alongside the checks for a first line that looks
> like a ChangeLog header or is just a single word).
> 


-- 
Nathan Sidwell