From: Eric Botcazou <botcazou@adacore.com>
To: Richard Biener <rguenther@suse.de>
Cc: Bernd Edlinger <bernd.edlinger@hotmail.de>,
gcc-patches@gcc.gnu.org, Arnaud Charlet <charlet@adacore.com>
Subject: Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions
Date: Tue, 10 Aug 2021 17:46:39 +0200 [thread overview]
Message-ID: <2208650.ElGaqSPkdT@arcturus> (raw)
In-Reply-To: <nycvar.YFH.7.76.2108100921290.11781@zhemvz.fhfr.qr>
> ISTR it was changed because at least with location info generated
> by gas there's no way to have "no location" for a portion of code.
> Instead the assigned location will be that of the previous .loc
> directive which results in random and confusing results for the
> pc range of the DECL_INGORED_P function.
Yes in the general case, but no if you put them at the beginning of the
assembly file (what the Ada compiler precisely does), at least if you do not
pass any -gdwarf-n switch now. This had worked for 2 decades at least...
> I guess we should really revisit the decision to rely on gas
> to produce line info. What's the advantage of doing so (apart
> from "nice" annotated assembly)?
Not a small advantage in my opinion, and I don't think that we want to change
it because of a corner case in Ada in any case.
I guess Bernd's patch is acceptable, modulo a small tweak for -gnatD. Let me
experiment a little bit though.
--
Eric Botcazou
next prev parent reply other threads:[~2021-08-10 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 16:45 Bernd Edlinger
2021-08-02 13:07 ` Eric Botcazou
2021-08-02 17:18 ` Bernd Edlinger
2021-08-04 14:33 ` Eric Botcazou
2021-08-04 17:59 ` Bernd Edlinger
2021-08-09 14:37 ` Eric Botcazou
2021-08-10 7:23 ` Richard Biener
2021-08-10 15:46 ` Eric Botcazou [this message]
2021-08-10 9:43 ` Bernd Edlinger
2021-08-10 20:56 ` Eric Botcazou
2021-08-11 5:27 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2208650.ElGaqSPkdT@arcturus \
--to=botcazou@adacore.com \
--cc=bernd.edlinger@hotmail.de \
--cc=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).