From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 352EF396D807 for ; Tue, 10 Aug 2021 15:46:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 352EF396D807 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x32e.google.com with SMTP id d131-20020a1c1d890000b02902516717f562so2847528wmd.3 for ; Tue, 10 Aug 2021 08:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yTBg0f3svupWIL9JCThZVufEQhhocgPlYIvci382w4Q=; b=Gi4sCUI23npa1g/hWw6XBSHOxjlAmoeRlBq/MJOYKdu7Djm8RdGOrkQZDf/0vSG8AP 06ZLMv419VXnkm1lSXXbo5SYnf/YglOgW+EpYvoxiPY+4UuKpHH+CX7fwgZqHNgTDM89 KxOMYxGCqxUBC6wJ5ZXmS//TrPKGPriZLdU6DWaW3f0pBlAU2ggDkF8kooSbPZZ2fSCO rgjDxxeOyv/IOWJGNMVz5jUOYeX/+XPYeUg2ZHNJJ4xbkwi+vSagub90dgYcH3KnZ/6h GZUJPW6ZINApmlw3UvXL4LWKdKYJ+/m2G3K7zFIXkuEVfenalimfaa9jNVANVUPUPmsz D9SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yTBg0f3svupWIL9JCThZVufEQhhocgPlYIvci382w4Q=; b=TqJwNR/WcrjPfRh0UmnVYb170CDjzPaZuZEB4YfIwAjhfRjMZK8xhdy0NLa7FQzr7Y IvYblLOU3agINTE6eWXA0IoBujsLTs6p9MJI5efLW43DAgrGRGUpzIG7mNMwxUynsdiw 3wpdo0tatoQSPGWJrZ/CAH5dRo7gcsytYDDtBH0iILr1pVuExgaGgespJ4vsQXPNxtEG Kizkh+J3ubRXPuLAKBWlLd6iHdjS5fSeZheOZxFg1n5l5vDZ0+64sTiJWhd9+sPLdyTZ AnbKN38tCayHQLJHL2VAabHXOm5khbqhpQmmA0CztJzIGSs9MEu7nBJ4M2Mae39519AP Xm4Q== X-Gm-Message-State: AOAM530/Ap2bA//b3sK/CkSndWPtHmjunrMEaqbsnynhmb1GWKbj8yPW ddxS2mcGViIVUv93e+fwE9IHVg== X-Google-Smtp-Source: ABdhPJyhmzlPQlmN8uU5/bxjzLem6GuEAn4eG0DHb0NQhSX6IO2zF7IvoSj75QDhgK2NW65XZBkfNQ== X-Received: by 2002:a7b:c204:: with SMTP id x4mr23015700wmi.70.1628610367313; Tue, 10 Aug 2021 08:46:07 -0700 (PDT) Received: from arcturus.localnet ([2a01:cb10:8647:7500:91f1:5b1d:74b:10d6]) by smtp.gmail.com with ESMTPSA id w14sm12595662wrt.23.2021.08.10.08.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 08:46:05 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Richard Biener Cc: Bernd Edlinger , gcc-patches@gcc.gnu.org, Arnaud Charlet Subject: Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions Date: Tue, 10 Aug 2021 17:46:39 +0200 Message-ID: <2208650.ElGaqSPkdT@arcturus> In-Reply-To: References: <1886121.usQuhbGJ8B@arcturus> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2021 15:46:09 -0000 > ISTR it was changed because at least with location info generated > by gas there's no way to have "no location" for a portion of code. > Instead the assigned location will be that of the previous .loc > directive which results in random and confusing results for the > pc range of the DECL_INGORED_P function. Yes in the general case, but no if you put them at the beginning of the assembly file (what the Ada compiler precisely does), at least if you do not pass any -gdwarf-n switch now. This had worked for 2 decades at least... > I guess we should really revisit the decision to rely on gas > to produce line info. What's the advantage of doing so (apart > from "nice" annotated assembly)? Not a small advantage in my opinion, and I don't think that we want to change it because of a corner case in Ada in any case. I guess Bernd's patch is acceptable, modulo a small tweak for -gnatD. Let me experiment a little bit though. -- Eric Botcazou