From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id BF4513858D33 for ; Tue, 21 Nov 2023 09:52:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF4513858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF4513858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700560330; cv=none; b=SZqaXG8Wy74aQpRm5+e4hGSg8QFN1HMPJIGuHpzuFrtvUumnKgFd/+6ghtDkkytSQSKoKOedwaPaDhkWVHhB22L2J4y0miqas/cUULFb1BWaTCfLY332lqJOaRBhnTL0zaVP8/O+cX1g+CgkoZUmMEKKfqbqN877m23A9AbBUV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700560330; c=relaxed/simple; bh=/tbYwh96qErQ1Wx+yF9FcCyHfX8ZnKYgfHXP57CLyPo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=v2gCQJiveIgoVQZ5XWyEOIDkXgd4sFleaLZ6PQ/RQ4T0YDoY+tPfffjilpQ685Gwj3HhGt14QL8LeKUELJ2bfcjKKYwum2MFEvn05Kc4oKPBxWSy5Y8PKKLIRJzLAMz1pGMq7gxJJXGfUHcUuNQNQl2Rn30GxpTT/XslOGDbLiQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AL9Mh1Z031220; Tue, 21 Nov 2023 09:52:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=WT5oDQ72QWbiTTe4iG4/FtGOqHbQX/bMk34zcRt3W1U=; b=ITK356qQm3wUJzVqvBwuGW3pBKpaKDaF+i4lplFCqYBBKpTUj0oKHg3O1GU5gXB2zkla PzlLWT65GrVcIiWBmsU+UVLrbnDYd4WT5vzoCApUq4V+2872mRwaXPYms4kQKGjBd6ZO ooofa/xjCEp0UpWHpg4oRuVWnH0MKkacNjmeubd/qNU0ZNZ2FBV8TXNNitfr6AHfCx+/ 1K4zHOGijhkZNT3RzRu4aPiLmmUi3LpeJRhvGz1j/DxTF0svlmy3nhAaBngT5IqQXddt uVexAMwvA417mwka0weICxGC97LEm/lHgWdE6ovBo801ZKaTdFAg89PT7furafy9Pesk fA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ugsv395hn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 09:52:08 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AL9exP0023773; Tue, 21 Nov 2023 09:52:07 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ugsv395h7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 09:52:07 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AL8kbT6005650; Tue, 21 Nov 2023 09:52:06 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uf7kt00x9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 09:52:06 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AL9q5Ck10552048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2023 09:52:06 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D45BD58052; Tue, 21 Nov 2023 09:52:05 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B49CD58062; Tue, 21 Nov 2023 09:52:03 +0000 (GMT) Received: from [9.43.7.24] (unknown [9.43.7.24]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 21 Nov 2023 09:52:03 +0000 (GMT) Message-ID: <2226bf1c-bc71-4a83-87c8-b07dab9454d6@linux.ibm.com> Date: Tue, 21 Nov 2023 15:22:01 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rtl-optimization: Modify loop live data with livein of loop header Content-Language: en-US From: Ajit Agarwal To: Richard Biener Cc: gcc-patches , Jeff Law , Segher Boessenkool , Peter Bergner References: <033c8799-cbdf-4d57-8d96-af33841d1a4f@linux.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TgOICduX1YFHAQYNHWpvTfCWtMTd4ayI X-Proofpoint-ORIG-GUID: wJ2b7BzU3Ggpx9qhK18_NTb4FV4mM9HQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_03,2023-11-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 mlxlogscore=996 lowpriorityscore=0 clxscore=1015 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210077 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/11/23 3:15 pm, Ajit Agarwal wrote: > > > On 21/11/23 3:02 pm, Richard Biener wrote: >> On Tue, Nov 21, 2023 at 9:30 AM Ajit Agarwal wrote: >>> >>> Hello All: >>> >>> This patch marked LOOP_DATA->live as the livein at the loop header basic >>> block. This is because Livein at each basic block is live in at the loop header. >> >> The current code does the same, you now have fewer regs live. In fact >> your patch removes all of the settings since when >> loop->aux == NULL there's no LOOP_DATA (loop), so you never do anything. >> > > Sorry for the inconvenience caused. I forgot to remove the check loop-aux == NULL > in the patch that I sent. > > My mistake. Sorry for that. > > Thanks & Regards > Ajit I did copy from one directory to another and forgot to remove loop->aux == NULL check in the patch that I sent. My mistake. But anyhow I have tested without that check. Sorry for inconvenience caused. I will make sure this wont happen again in the future patches. Thanks & Regards Ajit >> It appears that you do not fully grasp the changes done by your >> patches - you need to improve >> in this regard and either provide better explanations or stop sending these kind >> of patches. >> >> I will stop looking at your patches now, it appears to be a waste of >> my precious time. >> >> Peter - please work with Ajit here. >> >> Thanks, >> Richard. >> >> >>> Bootstrapped and regtested on powerpc64-linux-gnu. >>> >>> SPEC CPU 2017 benchmarks score is better than trunk wit this >>> change for INT and FP benchmarks. >>> >>> THanks & Regards >>> Ajit >>> >>> >>> rtl-optimization: Modify loop live data with livein of loop header >>> >>> Livein at each basic block is live in at the loop header. >>> Marked LOOP_DATA->live as the livein at the loop header basic >>> block. >>> >>> 2023-11-21 Ajit Kumar Agarwal >>> >>> gcc/ChangeLog: >>> >>> * loop-invariant.cc (calculate_loop_reg_pressure): Mark >>> LOOP_DATA->live as the livein at the loop header basic block. >>> --- >>> gcc/loop-invariant.cc | 11 ++++++----- >>> 1 file changed, 6 insertions(+), 5 deletions(-) >>> >>> diff --git a/gcc/loop-invariant.cc b/gcc/loop-invariant.cc >>> index a9b156682bc..c15e6168d5d 100644 >>> --- a/gcc/loop-invariant.cc >>> +++ b/gcc/loop-invariant.cc >>> @@ -2169,17 +2169,18 @@ calculate_loop_reg_pressure (void) >>> } >>> ira_setup_eliminable_regset (); >>> bitmap_initialize (&curr_regs_live, ®_obstack); >>> + >>> + /* Livein (loop_hdr) is live at each of the loop basic blocks. */ >>> + for (auto loop : loops_list (cfun, 0)) >>> + if (loop->aux == NULL) >>> + bitmap_ior_into (&LOOP_DATA (loop)->regs_live, DF_LR_IN (loop->header)); >>> + >>> FOR_EACH_BB_FN (bb, cfun) >>> { >>> curr_loop = bb->loop_father; >>> if (curr_loop == current_loops->tree_root) >>> continue; >>> >>> - for (class loop *loop = curr_loop; >>> - loop != current_loops->tree_root; >>> - loop = loop_outer (loop)) >>> - bitmap_ior_into (&LOOP_DATA (loop)->regs_live, DF_LR_IN (bb)); >>> - >>> bitmap_copy (&curr_regs_live, DF_LR_IN (bb)); >>> for (i = 0; i < ira_pressure_classes_num; i++) >>> curr_reg_pressure[ira_pressure_classes[i]] = 0; >>> -- >>> 2.39.3 >>>