From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 0A0B33858432 for ; Wed, 22 Dec 2021 15:00:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A0B33858432 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4DDBD6E; Wed, 22 Dec 2021 07:00:49 -0800 (PST) Received: from [10.57.0.71] (unknown [10.57.0.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 24CCD3F774; Wed, 22 Dec 2021 07:00:49 -0800 (PST) Subject: Re: [PATCH v3 2/2][GCC] arm: Declare MVE types internally via pragma To: Murray Steele Cc: gcc-patches@gcc.gnu.org References: <55ba6a8c-4dda-c023-0e93-a052e4830d06@arm.com> <342ef4e3-6013-2d67-adc8-6310febe2f52@foss.arm.com> <2a59e081-0a5f-5b9b-c398-d89c6c217822@arm.com> <9ccc226a-fdf7-d465-6074-b6a78d16b316@arm.com> <060230b8-22b0-36eb-2594-c469efaabf35@arm.com> <3ad22fca-fa13-04ea-f114-01e8c52dd280@foss.arm.com> <9849efef-a0db-825a-2473-8f71dc2412b6@foss.arm.com> <03099bb4-1dcf-aae5-3d77-7112ae22948a@arm.com> From: Richard Earnshaw Message-ID: <222b4c25-da44-8633-17b3-409a675e66e6@foss.arm.com> Date: Wed, 22 Dec 2021 15:00:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <03099bb4-1dcf-aae5-3d77-7112ae22948a@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3491.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Dec 2021 15:00:51 -0000 On 09/12/2021 15:24, Murray Steele via Gcc-patches wrote: > Changes from original patch: > > 1. Make mentioned changes to changelog. > 2. Add namespace-end comments. > 3. Add #error for when arm-mve-builtins.def is included without > defining DEF_MVE_TYPE. > 4. Make placement of '#undef DEF_MVE_TYPE' consistent. > > --- > > This patch moves the implementation of MVE ACLE types from > arm_mve_types.h to inside GCC via a new pragma, which replaces the prior > type definitions. This allows for the types to be used internally for > intrinsic function definitions. > > Bootstrapped and regression tested on arm-none-linux-gnuabihf, and > regression tested on arm-eabi -- no issues. > > Thanks, > Murray > > gcc/ChangeLog: > > * config.gcc: Add arm-mve-builtins.o to extra_objs. > * config/arm/arm-c.c (arm_pragma_arm): Handle "#pragma GCC arm". > (arm_register_target_pragmas): Register it. > * config/arm/arm-protos.h: (arm_mve::arm_handle_mve_types_h): New > prototype. > * config/arm/arm_mve_types.h: Replace MVE type definitions with > new pragma. > * config/arm/t-arm: (arm-mve-builtins.o): New target rule. > * config/arm/arm-mve-builtins.cc: New file. > * config/arm/arm-mve-builtins.def: New file. > * config/arm/arm-mve-builtins.h: New file. > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/mve/mve.exp: Add new subdirectories. > * gcc.target/arm/mve/general-c/type_redef_1.c: New test. > * gcc.target/arm/mve/general/double_pragmas_1.c: New test. > * gcc.target/arm/mve/general/nomve_1.c: New test. > I fixed a minor issue in the changelog (config.gcc needs to mention arm*-*-* as the 'function') and pushed this. Thanks, R.