From: Jeff Law <jeffreyalaw@gmail.com>
To: apinski@marvell.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 4/7] Allow match-and-simplified phiopt to run in early phiopt
Date: Thu, 24 Jun 2021 10:23:58 -0600 [thread overview]
Message-ID: <22551bfb-3bb3-1379-5826-37dae90cac81@gmail.com> (raw)
In-Reply-To: <1624486755-12879-5-git-send-email-apinski@marvell.com>
On 6/23/2021 4:19 PM, apinski--- via Gcc-patches wrote:
> From: Andrew Pinski <apinski@marvell.com>
>
> To move a few things more to match-and-simplify from phiopt,
> we need to allow match_simplify_replacement to run in early
> phiopt. To do this we add a replacement for gimple_simplify
> that is explictly for phiopt.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no
> regressions.
>
> gcc/ChangeLog:
>
> * tree-ssa-phiopt.c (match_simplify_replacement):
> Add early_p argument. Call gimple_simplify_phiopt
> instead of gimple_simplify.
> (tree_ssa_phiopt_worker): Update call to
> match_simplify_replacement and allow unconditionally.
> (phiopt_early_allow): New function.
> (gimple_simplify_phiopt): New function.
So the two questions on my end are why did we restrict when this could
run before and why restrict the codes we're willing to optimize in the
early phase? Not an ACK or NAK at this point, just trying to understand
a bit of the history.
jeff
next prev parent reply other threads:[~2021-06-24 16:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 22:19 [PATCH 0/7] PHI-OPT move abs_replacement to match.pd apinski
2021-06-23 22:19 ` [PATCH 1/7] Expand the comparison argument of fold_cond_expr_with_comparison apinski
2021-06-24 15:11 ` Jeff Law
2021-06-23 22:19 ` [PATCH 2/7] Reset the range info on the moved instruction in PHIOPT apinski
2021-06-24 15:11 ` Jeff Law
2021-06-23 22:19 ` [PATCH 3/7] Duplicate the range information of the phi onto the new ssa_name apinski
2021-06-24 15:16 ` Jeff Law
2021-06-26 6:21 ` Andrew Pinski
2021-06-23 22:19 ` [PATCH 4/7] Allow match-and-simplified phiopt to run in early phiopt apinski
2021-06-24 16:23 ` Jeff Law [this message]
2021-06-25 8:24 ` Richard Biener
2021-06-29 15:17 ` Jeff Law
2021-06-23 22:19 ` [PATCH 5/7] Try inverted comparison for match_simplify in phiopt apinski
2021-06-24 13:02 ` Bernhard Reutner-Fischer
2021-06-24 15:17 ` Jeff Law
2021-06-23 22:19 ` [PATCH 6/7] Lower for loops before lowering cond in genmatch apinski
2021-06-24 16:25 ` Jeff Law
2021-06-23 22:19 ` [PATCH 7/7] Port most of the A CMP 0 ? A : -A to match apinski
2021-06-24 15:19 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22551bfb-3bb3-1379-5826-37dae90cac81@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).