public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: waffl3x <waffl3x@protonmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v8 1/4] c++: P0847R7 (deducing this) - prerequisite changes. [PR102609]
Date: Tue, 9 Jan 2024 15:58:54 -0500	[thread overview]
Message-ID: <2270f47c-f117-46a7-863e-f4cbfe03925b@redhat.com> (raw)
In-Reply-To: <qFJs-vqcMVgr5VFvNrULQ3BL2GM2v_qgabqCA6KH3aDONEBK2La5VDARf_AJplVr5hafQ2T7SO6eQLh3omCRDfONNa2_p_mcsZWmPmM0Ajc=@protonmail.com>

On 1/6/24 19:00, waffl3x wrote:
> Bootstrapped and tested on x86_64-linux with no regressions.
> 
> I'm considering this finished, I have CWG2586 working but I have not
> included it in this version of the patch. I was not happy with the
> amount of work I had done on it. I will try to get it finished before
> we get cut off, and I'm pretty sure I can. I just don't want to risk
> missing the boat for the whole patch just for that.
> 
> There aren't too many changes from v7, it's mostly just cleaned up.
> There are a few though, so do take a look, if there's anything severe I
> can rush to fix it if necessary.
> 
> That's all, hopefully all is good, fingers crossed.

Great.  Given where we are in the release cycle, I'm thinking to put 
these with only minimal changes and then do any further adjustments 
afterward.

For this first one, I needed to fix the commit message to wrap at 75 
columns so that it fits in 80 columns with the initial padding added by 
'git log'.  I also needed to adjust the ChangeLog entry to please git 
gcc-verify.  And I changed the credit note to a Co-authored-by.

The other commit messages only needed wrapping.

Thanks!

Jason


  reply	other threads:[~2024-01-09 20:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-07  0:00 waffl3x
2024-01-09 20:58 ` Jason Merrill [this message]
2024-01-09 21:26   ` waffl3x
2024-01-09 21:56   ` Jason Merrill
2024-01-09 22:34     ` waffl3x
2024-01-09 22:52       ` Jason Merrill
2024-01-09 23:59         ` waffl3x
2024-01-10 17:15 ` Patrick Palka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2270f47c-f117-46a7-863e-f4cbfe03925b@redhat.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=waffl3x@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).