From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 899FE3858D32 for ; Mon, 10 Jul 2023 16:48:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 899FE3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36AGF1Ie011465; Mon, 10 Jul 2023 16:47:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : to : cc : from : subject : content-type : content-transfer-encoding; s=pp1; bh=61Cj+vK/8nWhGXGIkciK9pZeN0TXhfyyV/fL3n0WjEE=; b=VLApnKklZoPfrWiiHPEugP7GHsqzBnGv/idD8tZ14bDhbL04VIE5lS2QcJpzWV48utgA oQiH7hTkdU0cGsRLH3La74v4Silnv54KgFyFpinHVqZCEXw1uEYA3npt1USj00//B7um /BAzWoqa12Y8AK/4VcFvEysSJ2yW5S8aGBv6jLE8G4uJv+k1aQBYeDs0n9oAKfSWIzDx UrYfZybnm4IKOHFJIWXdFa7JaYRg9G8otMKKHWaWiASJ7STrm0aDmiHLZ0q/uEV0sAw7 QhUgPg2h0ekS1kIlXyAmLzNGo1bKXH+LVQweu7DdFSyXUVeDqbxC07fLriVLrNeLGmut ww== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rrmyu1kvp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 16:47:58 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36AGUWUf017135; Mon, 10 Jul 2023 16:47:58 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([9.208.130.99]) by ppma01dal.us.ibm.com (PPS) with ESMTPS id 3rpye6ru0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 16:47:58 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36AGlu0p16908762 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Jul 2023 16:47:56 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87A1B58059; Mon, 10 Jul 2023 16:47:56 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E3C6658043; Mon, 10 Jul 2023 16:47:55 +0000 (GMT) Received: from [9.61.182.134] (unknown [9.61.182.134]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 10 Jul 2023 16:47:55 +0000 (GMT) Message-ID: <227dcbda-843a-bcf1-5534-6ea2739e4355@linux.ibm.com> Date: Mon, 10 Jul 2023 11:47:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: GCC Patches Cc: Segher Boessenkool , Michael Meissner , "Kewen.Lin" From: Peter Bergner Subject: [PATCH, OBVIOUS] rs6000: Remove redundant MEM_P predicate usage Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: FTSE3MyWvgvDTc5aRl8CrN5i6wQ--aMm X-Proofpoint-ORIG-GUID: FTSE3MyWvgvDTc5aRl8CrN5i6wQ--aMm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-10_12,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015 impostorscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307100149 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While helping someone on the team debug an issue, I noticed some redundant tests in a couple of our predicates which can be removed. I'm going to commit the following as obvious once bootstrap and regtesting come back clean. Peter rs6000: Remove redundant MEM_P predicate usage The quad_memory_operand and vsx_quad_dform_memory_operand predicates contain a (match_code "mem") test, making their MEM_P usage redundant. Remove them. gcc/ * config/rs6000/predicates.md (quad_memory_operand): Remove redundant MEM_P usage. (vsx_quad_dform_memory_operand): Likewise. diff --git a/gcc/config/rs6000/predicates.md b/gcc/config/rs6000/predicates.md index 8479331482e..3552d908e9d 100644 --- a/gcc/config/rs6000/predicates.md +++ b/gcc/config/rs6000/predicates.md @@ -912,7 +912,7 @@ (define_predicate "quad_memory_operand" if (!TARGET_QUAD_MEMORY && !TARGET_SYNC_TI) return false; - if (GET_MODE_SIZE (mode) != 16 || !MEM_P (op) || MEM_ALIGN (op) < 128) + if (GET_MODE_SIZE (mode) != 16 || MEM_ALIGN (op) < 128) return false; return quad_address_p (XEXP (op, 0), mode, false); @@ -924,7 +924,7 @@ (define_predicate "quad_memory_operand" (define_predicate "vsx_quad_dform_memory_operand" (match_code "mem") { - if (!TARGET_P9_VECTOR || !MEM_P (op) || GET_MODE_SIZE (mode) != 16) + if (!TARGET_P9_VECTOR || GET_MODE_SIZE (mode) != 16) return false; return quad_address_p (XEXP (op, 0), mode, false);