From: Lehua Ding <lehua.ding@rivai.ai>
To: Robin Dapp <rdapp.gcc@gmail.com>, gcc-patches@gcc.gnu.org
Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, palmer@rivosinc.com,
jeffreyalaw@gmail.com
Subject: Re: [PATCH] RISC-V: Add conditional sign/zero extension and truncation autovec patterns
Date: Thu, 24 Aug 2023 18:27:03 +0800 [thread overview]
Message-ID: <22C69300351CBDDF+72f2ea8e-cfe7-4171-b0e5-49edf35365e0@rivai.ai> (raw)
In-Reply-To: <e25ad89f-8ff7-028d-e3c6-aee209d28bee@gmail.com>
On 2023/8/24 18:20, Robin Dapp wrote:
>
>> Yes, it's better to call it one_quad.
>
> I'd suggest to go with quarter as before or quarter_width_op
> or something.
OK for quarter.
>
>>> Is this necessary for recognizing a different pattern?
>>
>> Are you saying that the testcases xxx-1 and xxx-2 are duplicated? If
>> so, I have no problem removing it and just keeping xxx-1 testcase
>> since it is still possible to cover my code.
>
> I was just curious why the NEW_TYPE bi = b[i] was necessary instead
> of using b[i] directly.
Oh, I think there is no difference between the two because the type of b
is NEW_TYPE. So it's okay to remove this statement.
--
Best,
Lehua
prev parent reply other threads:[~2023-08-24 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 11:03 Lehua Ding
2023-08-24 9:59 ` Robin Dapp
2023-08-24 10:16 ` Lehua Ding
2023-08-24 10:20 ` Robin Dapp
2023-08-24 10:27 ` Lehua Ding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22C69300351CBDDF+72f2ea8e-cfe7-4171-b0e5-49edf35365e0@rivai.ai \
--to=lehua.ding@rivai.ai \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@rivosinc.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).