From: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: James Greenhalgh <James.Greenhalgh@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Will Deacon <Will.Deacon@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>, nd <nd@arm.com>
Subject: Re: [RFC][AArch64] Add support for system register based stack protector canary access
Date: Mon, 03 Dec 2018 10:03:00 -0000 [thread overview]
Message-ID: <22b79ec1-1543-01b2-2be0-d19fc2aa1c41@arm.com> (raw)
In-Reply-To: <20181203095919.GT12380@tucnak>
On 03/12/2018 09:59, Jakub Jelinek wrote:
> On Mon, Dec 03, 2018 at 09:55:36AM +0000, Ramana Radhakrishnan wrote:
>> + if (aarch64_stack_protector_guard == SSP_GLOBAL
>> + && opts->x_aarch64_stack_protector_guard_offset_str)
>> + {
>> + error ("Incompatible options -mstack-protector-guard=global and"
>
> Diagnostic messages shouldn't start with capital letters (3 times in the
> patch), unless it is something that is capitalized always, even in the
> middle of sentences (say GNU etc.).
>
> Jakub
>
Sorry - will fix in next iteration.
Ramana
next prev parent reply other threads:[~2018-12-03 10:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 9:55 Ramana Radhakrishnan
2018-12-03 9:59 ` Jakub Jelinek
2018-12-03 10:03 ` Ramana Radhakrishnan [this message]
2018-12-03 15:31 ` Florian Weimer
2018-12-03 16:40 ` Ard Biesheuvel
2019-01-10 16:53 ` Ramana Radhakrishnan
2019-01-10 10:53 ` Ramana Radhakrishnan
2019-01-10 11:05 ` Jakub Jelinek
2019-01-10 12:51 ` Ramana Radhakrishnan
2019-01-10 15:49 ` James Greenhalgh
2019-01-10 15:55 ` Will Deacon
2019-01-10 16:49 ` Ramana Radhakrishnan
2019-01-19 17:30 ` Jakub Jelinek
2018-12-04 3:51 Wilco Dijkstra
2018-12-04 12:58 ` Florian Weimer
2018-12-07 14:51 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b79ec1-1543-01b2-2be0-d19fc2aa1c41@arm.com \
--to=ramana.radhakrishnan@arm.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Will.Deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).