From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-491490-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 33056 invoked by alias); 3 Dec 2018 10:03:45 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 33046 invoked by uid 89); 3 Dec 2018 10:03:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:Windows-1252
X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com
Received: from mail-eopbgr50041.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Dec 2018 10:03:42 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IMoNkxOV3V1bpBHoLSgHrR5EjZ4qsqLX5/VeoF8Srjc=; b=mGaDqkMJL3XleAXySB03fUoTpKVu0fr4XAqSbR+D0+CZI/GiaO4rzGe0wrEavjDC6mV3qkaz9SNIJjonhCWBSImq4nqFKVWajITncgbbj7VcEyBIXEjsfIHtGSTQNo2OPkVhZQ1ZSbKTL0jfWYTs+6TV/k4p5DiZ9MxM7Nx45ps=
Received: from AM4PR08MB2788.eurprd08.prod.outlook.com (10.171.191.18) by AM4PR08MB1075.eurprd08.prod.outlook.com (10.167.91.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1382.22; Mon, 3 Dec 2018 10:03:36 +0000
Received: from AM4PR08MB2788.eurprd08.prod.outlook.com ([fe80::8584:2893:f8fe:d054]) by AM4PR08MB2788.eurprd08.prod.outlook.com ([fe80::8584:2893:f8fe:d054%2]) with mapi id 15.20.1382.020; Mon, 3 Dec 2018 10:03:36 +0000
From: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
To: Jakub Jelinek <jakub@redhat.com>
CC: James Greenhalgh <James.Greenhalgh@arm.com>, Richard Earnshaw	<Richard.Earnshaw@arm.com>, Marcus Shawcroft <Marcus.Shawcroft@arm.com>,	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, Ard Biesheuvel	<ard.biesheuvel@linaro.org>, Will Deacon <Will.Deacon@arm.com>, Mark Rutland	<Mark.Rutland@arm.com>, nd <nd@arm.com>
Subject: Re: [RFC][AArch64] Add support for system register based stack protector canary access
Date: Mon, 03 Dec 2018 10:03:00 -0000
Message-ID: <22b79ec1-1543-01b2-2be0-d19fc2aa1c41@arm.com>
References: <7a5a57fa-629d-d2ff-6292-e0893647ec8a@arm.com> <20181203095919.GT12380@tucnak>
In-Reply-To: <20181203095919.GT12380@tucnak>
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ramana.Radhakrishnan@arm.com;
received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <4B743DD2412D82489E58EB2029DB832B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2018-12/txt/msg00064.txt.bz2

On 03/12/2018 09:59, Jakub Jelinek wrote:
> On Mon, Dec 03, 2018 at 09:55:36AM +0000, Ramana Radhakrishnan wrote:
>> +  if (aarch64_stack_protector_guard =3D=3D SSP_GLOBAL
>> +      && opts->x_aarch64_stack_protector_guard_offset_str)
>> +    {
>> +      error ("Incompatible options -mstack-protector-guard=3Dglobal and"
>=20
> Diagnostic messages shouldn't start with capital letters (3 times in the
> patch), unless it is something that is capitalized always, even in the
> middle of sentences (say GNU etc.).
>=20
> 	Jakub
>=20
Sorry - will fix in next iteration.

Ramana