Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

[Sandra Loosemore <sandra@codesourcery.com>]

On 10/27/22 04:09, Thomas Schwinge wrote:
> Hi!
> 
> On 2022-10-26T20:27:19-0600, Sandra Loosemore <sandra@codesourcery.com> wrote:
>> One of my test cases examines the .s output to make sure that the clones
>> are emitted as local symbols and not global.  I have not been able to
>> find the symbol linkage information in any of the dump files
> 
> Hmm, also some of '-fdump-ipa-all-details' doesn't help here?

Maybe I'm not looking at the right dump file, but all I see is names of 
functions in the dumps and nothing about symbol linkage/visibility, even 
with -details.

> And/or, where you implement the logic to "make sure that the clones
> are emitted as local symbols and not global", do emit some "tag" in the
> dump file, and the scan for that?
> 
> Random examples that I just remembered:
> 
> 'gcc/omp-offload.cc:execute_oacc_loop_designation' handling of
> 'OMP_CLAUSE_NOHOST', and how that's scanned (host-side) in test cases
> such as 'libgomp/testsuite/libgomp.oacc-c-c++-common/routine-nohost-1.c',
> 'libgomp/testsuite/libgomp.oacc-fortran/routine-nohost-1.f90'.
> 
> 'gcc/config/nvptx/nvptx.cc:nvptx_find_sese' doing
> 'fprintf (dump_file, "SESE regions:"); [...]', and that's scanned in:
> 
>      libgomp/testsuite/libgomp.oacc-c-c++-common/nvptx-sese-1.c-/* Match {N->N(.N)+} */
>      libgomp/testsuite/libgomp.oacc-c-c++-common/nvptx-sese-1.c:/* { dg-final { scan-offload-rtl-dump "SESE regions:.* \[0-9\]+{\[0-9\]+->\[0-9\]+(\\.\[0-9\]+)+}" "mach" } } */
> 
> (You'd be doing this at the 'scan-offload-tree-dump[...]' level, I
> suppose.)

I guess customizing the dump output from the simdclone pass with the 
information I need is the easiest solution.  I'm still concerned about 
getting adequate routine test coverage, though, when it's so specialized 
to a particular offload target.

Thanks for the help!  :-)

-Sandra