From: Jeff Law <law@redhat.com>
To: Oliver Browne <oliverbrowne627@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATH] Patch to fix -finstrument-functions-exclude-function-list handling of namespaces and escaped commas
Date: Thu, 04 Jul 2019 00:02:00 -0000 [thread overview]
Message-ID: <22d77a66-5753-978a-984e-e87906865de3@redhat.com> (raw)
In-Reply-To: <CAHYp2N8GKNvA9Nm5cpMbtkqwFj9fxBQVWypfc24GOwnwQYU=AQ@mail.gmail.com>
On 6/12/19 12:25 PM, Oliver Browne wrote:
> Patch fixes following PRs:
> c++/90816 - -finstrument-functions-exclude-function-list improperly
> handles namespace/class definitions
> c++/90809 - -finstrument-functions-exclude-function-list mishandles
> comma escaping
>
> Fixes as follows:
> At flag_instrument_functions_exclude_p [gimplify.c]
> Using lang_hooks.decl_printable_name (fndecl, 1) to get namespace /
> class information as part of printable name to allow for
> inclusion of namespace / class specification when passing symbols to
> -finstrument-functions-exclude-function-list. Was
> previously lang_hooks.decl_printable_name (fndecl, 0).
>
> At add_comma_separated_to_vector [opts.c]
> Added writing of a null character to w after primary loop finishes, to
> account for offset between r and w when r reaches end of
> passed string.
>
> from Oliver Browne <oliverbrowne627@gmail.com>
> PR c++/90816
> PR c++/90809
> * gimplify.c (flag_instrument_functions_exclude_p): include namespace
> information as part of decl name
> * opts.c (add_comma_separated_to_vector): add null character to correct
> position in last token added to token vector
> Index: gimplify.c
> ===================================================================
> --- gimplify.c 2019-06-12 19:07:26.872077000 +0100
> +++ gimplify.c 2019-06-12 18:55:10.609255000 +0100
> @@ -13987,11 +13987,17 @@ flag_instrument_functions_exclude_p (tre
> {
> const char *name;
> - int i;
> + unsigned int i;
> char *s;
>
> - name = lang_hooks.decl_printable_name (fndecl, 0);
> - FOR_EACH_VEC_ELT (*v, i, s)
> + name = lang_hooks.decl_printable_name (fndecl, 1);
> + for(i = 0; i < v->length(); i++){
> + s = (*v)[i];
> + if(strstr(name, s) != NULL){
> + return(true);
> + }
> + }
> +/* FOR_EACH_VEC_ELT (*v, i, s)
> if (strstr (name, s) != NULL)
> - return true;
> + return true;*/
> }
So why did you drop the FOR_EACH_VEC_ELT and open-code the loop? I
don't see that as being a necessary change. Leaving the
FOR_EACH_VEC_ELT in place would also avoid the mis-formatting you've
introduced as well as removing clutter of a commented-out hunk of code.
>
> @@ -14278,3 +14284,3 @@ gimplify_hasher::equal (const elt_t *p1,
>
> return true;
> -}
> \ No newline at end of file
> +}
> Index: opts.c
> ===================================================================
> --- opts.c 2019-06-12 19:10:04.354612000 +0100
> +++ opts.c 2019-06-12 18:53:43.675852000 +0100
> @@ -263,7 +263,8 @@ add_comma_separated_to_vector (void **pv
> *w++ = *r++;
> }
> - if (*token_start != '\0')
> + *w = '\0';
> + if (*token_start != '\0'){
> v->safe_push (token_start);
> -
> + }
> *pvec = v;
So why introduce the unnecessary { } scope? And why do it in a way that
is different than 99% of the other code in GCC (where the { and } will
be on individual lines with 2 spaces of indention?
Jeff
next prev parent reply other threads:[~2019-07-03 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 18:25 Oliver Browne
2019-07-04 0:02 ` Jeff Law [this message]
2019-07-04 8:28 ` Oliver Browne
2019-07-24 18:19 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22d77a66-5753-978a-984e-e87906865de3@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=oliverbrowne627@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).