From: Jeff Law <law@redhat.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
James Greenhalgh <James.Greenhalgh@arm.com>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH][AArch64] Simplify frame layout for stack probing
Date: Wed, 26 Jul 2017 19:16:00 -0000 [thread overview]
Message-ID: <2346b545-8740-a861-2855-14d5e81bb75e@redhat.com> (raw)
In-Reply-To: <DB6PR0801MB20538770C0B5E53FBBB7D48B83B80@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On 07/25/2017 07:58 AM, Wilco Dijkstra wrote:
> This patch makes some changes to the frame layout in order to simplify
> stack probing. We want to use the save of LR as a probe in any non-leaf
> function. With shrinkwrapping we may only save LR before a call, so it
> is useful to define a fixed location in the callee-saves. So force LR at
> the bottom of the callee-saves even with -fomit-frame-pointer.
>
> Also remove a rarely used frame layout that saves the callee-saves first
> with -fomit-frame-pointer.
>
> OK for commit (and backport to GCC7)?
>
> ChangeLog:
> 2017-07-25 Wilco Dijkstra <wdijkstr@arm.com>
>
> * config/aarch64/aarch64.c (aarch64_layout_frame):
> Ensure LR is always stored at the bottom of the callee-saves.
> Remove frame option which saves callee-saves at top of frame.
I'll let the appropriate aarch64 maintainers comment on correctness.
But I wanted to give an explicit thanks for simplifying this so that we
can rely on it.
Jeff
next prev parent reply other threads:[~2017-07-26 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 13:58 Wilco Dijkstra
2017-07-26 19:16 ` Jeff Law [this message]
2017-08-01 10:18 ` Wilco Dijkstra
2017-08-15 16:27 ` Wilco Dijkstra
2017-10-26 15:23 ` James Greenhalgh
2017-10-27 9:26 ` James Greenhalgh
2017-11-03 16:47 ` Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2346b545-8740-a861-2855-14d5e81bb75e@redhat.com \
--to=law@redhat.com \
--cc=James.Greenhalgh@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).