* [ping] 3 aarch64/arm/rs6000 patches
@ 2017-01-16 8:27 Eric Botcazou
2017-01-17 8:01 ` Alan Modra
0 siblings, 1 reply; 6+ messages in thread
From: Eric Botcazou @ 2017-01-16 8:27 UTC (permalink / raw)
To: gcc-patches
aarch64 (Enable descriptors for nested functions in Ada):
https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01253.html
arm (Enable descriptors for nested functions in Ada):
https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01254.html
rs6000 (Fix reload failures in 64-bit mode):
https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00568.html
Thanks in advance.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ping] 3 aarch64/arm/rs6000 patches
2017-01-16 8:27 [ping] 3 aarch64/arm/rs6000 patches Eric Botcazou
@ 2017-01-17 8:01 ` Alan Modra
2017-01-17 8:21 ` Eric Botcazou
0 siblings, 1 reply; 6+ messages in thread
From: Alan Modra @ 2017-01-17 8:01 UTC (permalink / raw)
To: Eric Botcazou, Segher Boessenkool; +Cc: gcc-patches
On Mon, Jan 16, 2017 at 09:26:53AM +0100, Eric Botcazou wrote:
> rs6000 (Fix reload failures in 64-bit mode):
> https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00568.html
The one thing I find questionable about this patch is that it will set
mem_alias_set for the resulting MEMs to the TOC alias set. Is that
correct for memory not in the TOC?
My guess is that in this case it is OK, because you're handling
constants forced to memory. By giving them a non-zero alias set
you're saying that they won't alias other mem accesses, which should
be true.
I'm commenting because when you first posted the patch, Segher asked
me whether I had any concerns and I replied with the first paragraph
or something like it. So I'm probably partly to blame for the delay
in review. The second paragraph is me rethinking that concern.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ping] 3 aarch64/arm/rs6000 patches
2017-01-17 8:01 ` Alan Modra
@ 2017-01-17 8:21 ` Eric Botcazou
2017-01-17 9:20 ` Alan Modra
0 siblings, 1 reply; 6+ messages in thread
From: Eric Botcazou @ 2017-01-17 8:21 UTC (permalink / raw)
To: Alan Modra; +Cc: gcc-patches, Segher Boessenkool
> The one thing I find questionable about this patch is that it will set
> mem_alias_set for the resulting MEMs to the TOC alias set. Is that
> correct for memory not in the TOC?
I don't understand why the memory would not be in the TOC (but I discovered
this TOC business while investigating the issue, nice invention ;-) Or rather
I don't understand why this would be a problem with the patch if this was not
already the case in the existing code.
The main difference between VxWorks and the other ports is that you cannot
create TOC entries manually, they are exclusively created by the linker; but
that's it, if they are created properly, they work as for the other ports.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ping] 3 aarch64/arm/rs6000 patches
2017-01-17 8:21 ` Eric Botcazou
@ 2017-01-17 9:20 ` Alan Modra
2017-01-17 10:01 ` Eric Botcazou
0 siblings, 1 reply; 6+ messages in thread
From: Alan Modra @ 2017-01-17 9:20 UTC (permalink / raw)
To: Eric Botcazou; +Cc: gcc-patches, Segher Boessenkool
On Tue, Jan 17, 2017 at 09:21:38AM +0100, Eric Botcazou wrote:
> > The one thing I find questionable about this patch is that it will set
> > mem_alias_set for the resulting MEMs to the TOC alias set. Is that
> > correct for memory not in the TOC?
>
> I don't understand why the memory would not be in the TOC
Um, why are you using use_toc_relative_ref then, if not to access MEMs
outside the TOC?
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ping] 3 aarch64/arm/rs6000 patches
2017-01-17 9:20 ` Alan Modra
@ 2017-01-17 10:01 ` Eric Botcazou
0 siblings, 0 replies; 6+ messages in thread
From: Eric Botcazou @ 2017-01-17 10:01 UTC (permalink / raw)
To: Alan Modra; +Cc: gcc-patches, Segher Boessenkool
> Um, why are you using use_toc_relative_ref then, if not to access MEMs
> outside the TOC?
OK, I guess I misunderstood what you meant by "memory not in the TOC", you are
probably referring to the MEM generated by the call to force_const_mem, which
indeed points outside the TOC for VxWorks.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ping] 3 aarch64/arm/rs6000 patches
@ 2016-12-12 9:12 Eric Botcazou
0 siblings, 0 replies; 6+ messages in thread
From: Eric Botcazou @ 2016-12-12 9:12 UTC (permalink / raw)
To: gcc-patches
aarch64 (Enable descriptors for nested functions in Ada):
https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01253.html
arm (Enable descriptors for nested functions in Ada):
https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01254.html
rs6000 (Fix reload failures in 64-bit mode):
https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00568.html
Thanks in advance.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-17 10:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-16 8:27 [ping] 3 aarch64/arm/rs6000 patches Eric Botcazou
2017-01-17 8:01 ` Alan Modra
2017-01-17 8:21 ` Eric Botcazou
2017-01-17 9:20 ` Alan Modra
2017-01-17 10:01 ` Eric Botcazou
-- strict thread matches above, loose matches on Subject: below --
2016-12-12 9:12 Eric Botcazou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).