From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18225 invoked by alias); 3 Feb 2011 16:25:15 -0000 Received: (qmail 18204 invoked by uid 22791); 3 Feb 2011 16:25:14 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2beaomr08.btconnect.com (HELO mail.btconnect.com) (213.123.26.186) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Feb 2011 16:25:08 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2beaomr08.btconnect.com with ESMTP id BOK68161; Thu, 03 Feb 2011 16:24:53 +0000 (GMT) Cc: Richard Henderson , Jeff Law , Richard Guenther , gcc-patches@gcc.gnu.org Message-Id: <23E2F999-12EC-4569-98DA-0A542A17FEF1@sandoe-acoustics.co.uk> From: IainS To: Jakub Jelinek In-Reply-To: <20110203162041.GS30899@tyan-ft48-01.lab.bos.redhat.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: Patch ping Date: Thu, 03 Feb 2011 16:25:00 -0000 References: <20110203115855.GR30899@tyan-ft48-01.lab.bos.redhat.com> <4D4AD45F.7060008@redhat.com> <20110203162041.GS30899@tyan-ft48-01.lab.bos.redhat.com> X-Mirapoint-IP-Reputation: reputation=Fair-1, source=Queried, refid=tid=0001.0A0B0301.4D4AD6D3.0138, actions=tag X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0207.4D4AD6D5.01CB,ss=1,fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=single engine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-02/txt/msg00212.txt.bz2 On 3 Feb 2011, at 16:20, Jakub Jelinek wrote: > On Thu, Feb 03, 2011 at 08:14:23AM -0800, Richard Henderson wrote: >> On 02/03/2011 03:58 AM, Jakub Jelinek wrote: >>> The following patch is awaiting review for a week: >>> >>> - http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02059.html >>> P1 PR31490, section flags conflict handling >> >> I think the second patch, attempting to keep the warnings in >> declaration order, >> is better. I don't think there's so much extra work to warrant the >> inconsistency. > > Thanks. > >> One change though, >> >>> /* Private flag applied to disable section-anchors in a particular >>> section. >>> This needs to be kept in sync with the flags used by varasm.c >>> (defined in >>> output.h). */ >>> -#define SECTION_NO_ANCHOR 0x2000000 >>> +#define SECTION_NO_ANCHOR 0x4000000 >> >> That ought to have been defined as (SECTION_MACH_DEP << 1). That >> does leave >> the comment slightly out of date -- "other machine-dependent uses" >> perhaps? > > Well, it perhaps could be just SECTION_MACH_DEP, at least I can't > see any > reasons why it couldn't, just the assert required that it was bigger: hmm, won't that output.h to be before every instance of darwin.h? > config/darwin.c: gcc_assert (SECTION_NO_ANCHOR > SECTION_MACH_DEP); > config/alpha/alpha.c:#define SECTION_PUBLIC SECTION_MACH_DEP > config/i386/winnt.c:#define SECTION_PE_SHARED SECTION_MACH_DEP > config/ia64/ia64.c:#define SECTION_VMS_OVERLAY SECTION_MACH_DEP > config/mep/mep.c:#define SECTION_MEP_VLIW SECTION_MACH_DEP > > darwin doesn't support alpha/ia64/mep (I hope) and is not winnt. > I just can't test it on Darwin. .... I can if you like, Iain > Jakub