From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73185 invoked by alias); 19 May 2016 19:25:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 73173 invoked by uid 89); 19 May 2016 19:25:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=headquarters, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 19 May 2016 19:25:31 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 838566409E; Thu, 19 May 2016 19:25:30 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-172.phx2.redhat.com [10.3.116.172]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4JJPT8l022650; Thu, 19 May 2016 15:25:30 -0400 Subject: Re: [PATCH v2] gcov: Runtime configurable destination output To: Aaron Conole , Nathan Sidwell References: <1456350732-8272-1-git-send-email-aconole@bytheb.org> Cc: gcc-patches@gcc.gnu.org, Jan Hubicka , Nathan Sidwell From: Jeff Law Message-ID: <23c4a1b3-343e-aa21-054a-b943ebf9cf6d@redhat.com> Date: Thu, 19 May 2016 19:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg01561.txt.bz2 On 05/19/2016 12:40 PM, Aaron Conole wrote: > Nathan Sidwell writes: > >> On 02/24/16 16:52, Aaron Conole wrote: >>> The previous gcov behavior was to always output errors on the stderr channel. >>> This is fine for most uses, but some programs will require stderr to be >>> untouched by libgcov for certain tests. This change allows configuring >>> the gcov output via an environment variable which will be used to open >>> the appropriate file. >> >> this is ok in principle. I have a couple of questions & nits below though. > > Thank you for the consideration. I will be submitting a new patch that > I hope fully addresses your comments below, either tomorrow or Monday. > > Thanks so much for the review. > >> I don't see a previous commit from you -- do you have a copyright >> assignment with the FSF? (although this patch is simple, my guess is >> the idea it implements is sufficiently novel to need one). We can >> handle that off list. > > I'm happy to report that I did send in some FSF paperwork this week. > Hopefully it is on record now, but even if it isn't I live a train ride > away from the FSF headquarters so I'd be happy to take the time to make > sure it's all signed correctly. Also note that Aaron works for Red Hat and should be covered by our existing assignments. jeff