From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 8F0B23858D1E for ; Sat, 8 Apr 2023 18:46:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F0B23858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-5180af0e886so53029a12.2 for ; Sat, 08 Apr 2023 11:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680979614; x=1683571614; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ecbGEZM5oMleVKJTnSO8nkTt/itkvy3TzMJCkM7EwRw=; b=gZBbIZ/PmhWSB7wWYZvT2HPVyWbVuhYGY3xF4fD8Oxv2uLXODE+inWz/CaDhpvavXl XY9TUHSaSnge4uiobLTBgKluSiS+hAqFRitnDhYJEm3wCTVqUr4mhgQwc3gMLldcV/w1 EUej2nPptw/7djwaPTpzG0FBQaJmWq4PnSEtv6VS8xtqnuCoNZrwa7s7q/Fp2clBPw2L 45RO/75QgcIeTb7nCoRy3uatrWji/MaNSqMikvTBRKaQXI+Hin8mydEtGFqSiMBh7wSK bTM0/8ihp541HNQPzjneacECgB5Q3WOqR6/hoEdy/yUTdE2KdC7mbd44sU59EOc070hU pTog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680979614; x=1683571614; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ecbGEZM5oMleVKJTnSO8nkTt/itkvy3TzMJCkM7EwRw=; b=75oIN9+mDPVQimEvgxdbGDQ6xYJo6JC8BB9rWqkNMxH2w/cCuOAfMtNILQRTzXRMm/ aF1+e5ls2cA/rSgxrvOw9GebcN4aJcWCCCjk6lcKmXTEOFTB8X6PTvPHI1u+Be501XNT nWrU1h1ZgJhpOw6yAO67JUj2fR16ljaBUJj58VHsMfFuaEpF9n93m/LJ6g4kobcjIhYP CJjk07ESwaZYvDXU4qFNv1Mva/ISwNbvuECHfDlENunb5x09q/eTeucOmQMUwrXL/Or5 9rr6rLDsR3huwC1t3IGkqhBHx+pzGrpS5TYyVGR7pH6vueBhEsORFv+c87ESEWYuc+Jm IB5w== X-Gm-Message-State: AAQBX9dATTLvNxnC6Yr8Mp6g3Sr9kOsKXWRLyE01XLqaAgwF0dkr3VY2 TgqvVEGv1e+cH8q3dUMOxI4= X-Google-Smtp-Source: AKy350bzDQAYfLxfiH7pfMZDT7d9A9u1qaHL77iSnRIZDVxPKO4xiU3gIrluWdEB7vmz7DvQmV5bwQ== X-Received: by 2002:aa7:9573:0:b0:625:cb74:9e01 with SMTP id x19-20020aa79573000000b00625cb749e01mr5932930pfq.25.1680979614393; Sat, 08 Apr 2023 11:46:54 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id j16-20020a62e910000000b006258dd63a3fsm5031620pfh.56.2023.04.08.11.46.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Apr 2023 11:46:53 -0700 (PDT) Message-ID: <23e1f98e-1015-6219-2467-8c908be91632@gmail.com> Date: Sat, 8 Apr 2023 12:46:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V4] RISC-V: Fix a redefinition bug for the fd-4.c Content-Language: en-US To: shiyulong@iscas.ac.cn, gcc-patches@gcc.gnu.org Cc: palmer@dabbelt.com, kito.cheng@sifive.com, jim.wilson.gcc@gmail.com, wuwei2016@iscas.ac.cn, jiawei@iscas.ac.cn, shihua@iscas.ac.cn, dje.gcc@gmail.com, mirimmad@outlook.com, pinskia@gmail.com, David Malcolm References: <20230407033702.6770-1-shiyulong@iscas.ac.cn> From: Jeff Law In-Reply-To: <20230407033702.6770-1-shiyulong@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/6/23 21:37, shiyulong@iscas.ac.cn wrote: > From: yulong > > This patch fix a redefinition bug. > There are have a definition about mode_t in the fd-4.c, but it duplicates the definition in types.h that be included by stdio.h. > > gcc/testsuite/ChangeLog: > > * gcc.dg/analyzer/fd-4.c: delete the definition of mode_t. This may not be advisable. I wouldn't be shocked to find out there are systems that do not provide mode_t. Ultimately David Malcolm (on cc) should make the final decision here. It's really not a RISC-V problem. jeff