From: Sandra Loosemore <sandra@codesourcery.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Cc: <sgk@troutmask.apl.washington.edu>
Subject: [Fortran] Fix broken use of alloca in C interoperability testcase
Date: Mon, 25 Oct 2021 12:27:18 -0600 [thread overview]
Message-ID: <242ab49c-5047-c7fe-ee06-23210f3bbe18@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
This patch is for PR102910. There's no reason why the testcase in
question needs to use alloca, but I wasn't aware there were portability
issues with it until I saw this issue.
I think this fix is probably obvious and will commit it tomorrow unless
I get some feedback on it meanwhile.
-Sandra
[-- Attachment #2: pr102910.patch --]
[-- Type: text/x-patch, Size: 1307 bytes --]
commit 75b603334401d079391ca950dd2e22663cdb3080
Author: Sandra Loosemore <sandra@codesourcery.com>
Date: Mon Oct 25 11:08:28 2021 -0700
[Fortran] Fix broken use of alloca in C interoperability testcase
2021-10-25 Sandra Loosemore <sandra@codesourcery.com>
gcc/testsuite/
PR testsuite/102910
* gfortran.dg/c-interop/cf-descriptor-5-c.c: Use a static buffer
instead of alloca.
diff --git a/gcc/testsuite/gfortran.dg/c-interop/cf-descriptor-5-c.c b/gcc/testsuite/gfortran.dg/c-interop/cf-descriptor-5-c.c
index 12464b5..320a354 100644
--- a/gcc/testsuite/gfortran.dg/c-interop/cf-descriptor-5-c.c
+++ b/gcc/testsuite/gfortran.dg/c-interop/cf-descriptor-5-c.c
@@ -1,6 +1,5 @@
#include <stdlib.h>
#include <stdio.h>
-#include <alloca.h>
#include <ISO_Fortran_binding.h>
#include "dump-descriptors.h"
@@ -8,12 +7,18 @@
extern void ctest (int n);
extern void ftest (CFI_cdesc_t *a, int n);
+#define BUFSIZE 512
+static char adata[BUFSIZE];
+
void
ctest (int n)
{
CFI_CDESC_T(0) adesc;
CFI_cdesc_t *a = (CFI_cdesc_t *) &adesc;
- char *adata = (char *) alloca (n);
+
+ /* Use a fixed-size static buffer instead of allocating one dynamically. */
+ if (n > BUFSIZE)
+ abort ();
/* Fill in adesc. */
check_CFI_status ("CFI_establish",
reply other threads:[~2021-10-25 18:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=242ab49c-5047-c7fe-ee06-23210f3bbe18@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).