From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-h1p-028595.sys.comcast.net (resqmta-h1p-028595.sys.comcast.net [IPv6:2001:558:fd02:2446::3]) by sourceware.org (Postfix) with ESMTPS id B8E7C3858C2C for ; Fri, 1 Dec 2023 17:21:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8E7C3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=comcast.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=comcast.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B8E7C3858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:558:fd02:2446::3 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701451296; cv=none; b=HdF/1hFDIGBAptU9qAA651vyK4bBtDvmS7la6Ezoa23zbQkPG4wzu8v8N7ew81sXnayciYduqp8MRJtFwHQG8Ds+/+92vZOTBd+NVX+4qfLYV3AnL6BOnxBfxQQ9WB/zXCO1rI/W4Np1b3TTNKlnj2k8D66oDDxqoKdqSPQGIEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701451296; c=relaxed/simple; bh=cMGRI0cYjDRIgApEYSKwOfeWBQn0BBWLaynQJxMtl6M=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=fAJVB2Xe6mfFkkEUXNpSE/zwREuxUIQTOr+3vGvIsHScz/l7yqeWxso2LI31/iGPC2pW0ks97vmRUtKNamdLLcqHUOlpNmTW9zgWFdjVsyL2TBvC8K4titf0V9CSVBHHgB7g9gff7k1Exc8c8ksBSHTVr44FHmAkdWDoJgpwp54= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from resomta-h1p-028517.sys.comcast.net ([96.102.179.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resqmta-h1p-028595.sys.comcast.net with ESMTP id 94DVr7FN0QLPx97CnrVHXT; Fri, 01 Dec 2023 17:21:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1701451293; bh=L1DX0d8nLM/yu0iEzLwa+9j7LLeUv1/cx1QMlkNBWd0=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To:Xfinity-Spam-Result; b=qDk09foUfRyM7xZtcGZD+5LGSDCmcAlBYNnfCEPvvQPGmKReXXB8ZLmtBDAPnWFSs QT1ubire6Z6hBWPX00KaBxqJhrYnCz8oK2g6BHhMqkGeOP4VOAM5GZ5Fw7zFcVIikI OgqUV+6N/76r3qF2Ti4haEuulqYGcz/ayCFPLh4ql16GLypQdnHrJDYuaBMwxgmW7W D6Wu93Nmw9IOsAccsD4Pz3hnkLVquaPTZyhorcwVb7N8jrzlGMSc3iRZaEFcVr/4T4 fBk3q9bag7dETMYhyxZ4fMwXEJmV3gv7Af4BXYGjHGkBO4hjGmY9oxFl5DNuHKIwCC 6UvjvhpIZKNEw== Received: from smtpclient.apple ([IPv6:2601:644:907f:7c80:5887:9515:1f17:3a9d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resomta-h1p-028517.sys.comcast.net with ESMTPSA id 97ClrajaH1UyB97CmrTH2E; Fri, 01 Dec 2023 17:21:33 +0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH] testsuite: refine gcc.dg/analyzer/fd-4.c test for newlib From: Mike Stump In-Reply-To: <20231106110153.3863209-1-poulhies@adacore.com> Date: Fri, 1 Dec 2023 09:21:30 -0800 Cc: gcc-patches@gcc.gnu.org, dmalcolm@redhat.com Content-Transfer-Encoding: quoted-printable Message-Id: <2438398F-C329-43D6-9EFC-C029DC292F80@comcast.net> References: <20231106110153.3863209-1-poulhies@adacore.com> To: =?utf-8?Q?Marc_Poulhi=C3=A8s?= X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 6, 2023, at 3:01 AM, Marc Poulhi=C3=A8s = wrote: >=20 > Contrary to glibc, including stdio.h from newlib defines mode_t which > conflicts with the test's type definition. >=20 > .../gcc/testsuite/gcc.dg/analyzer/fd-4.c:19:3: error: redefinition of = typedef 'mode_t' with different type > ... > .../include/sys/types.h:189:25: note: previous declaration of 'mode_t' = with type 'mode_t' {aka 'unsigned int'} >=20 > Defining _MODE_T_DECLARED skips the type definition. >=20 > gcc/testsuite/ChangeLog: >=20 > * gcc.dg/analyzer/fd-4.c: Fix for newlib. > --- > Tested on x86_64-linux and x86_64-elf. >=20 > Ok for master? Ok,