From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 28D293858D28 for ; Tue, 29 Aug 2023 15:17:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28D293858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37TF8Tj2032145; Tue, 29 Aug 2023 15:17:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=jNs2zbwZhtGv4VWkAze1NBgWlRZqmQw1hKp9hNqTZYU=; b=ChHe/TihpAS0DPjZDEf2rXfyqvlZ1p39gcnfGRE92vC/FV/R7CW7HR++LVdmTmlLPLxU ojNCt0MfwVopWproxl6xTXQWAOlOLZN3ffY8BpngGQALOsqMhQxx67YeBxVknce2Cx+J M/Pk9saT/ZpVdswi+4VOomuG5l5yL2j9Sv7QC5vbMb2oz1Gwz/542qac73rAX1TaG1kh TEPwdr9yy3HxuEa8Lph/Qu+cHZj+5GSL/azW79nSG4vA071jS8zxdXILW8s0JN0ywa+M cWpFdpkiEK0MVKc4yDSHhcRuZWaEXMya9p9lIoBFy4ufBw7l3VWcuPWamDSBULaWbLZ9 VA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ssjvr0n3u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 15:17:48 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37TFA7lr007763; Tue, 29 Aug 2023 15:17:48 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ssjvr0n3c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 15:17:48 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37TDrtKh014107; Tue, 29 Aug 2023 15:17:47 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3sqwxjuyak-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 15:17:47 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37TFHjjT3605176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Aug 2023 15:17:46 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1D5B5805A; Tue, 29 Aug 2023 15:17:45 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ABA0958051; Tue, 29 Aug 2023 15:17:44 +0000 (GMT) Received: from wecm-9-67-137-54.wecm.ibm.com (unknown [9.67.137.54]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 29 Aug 2023 15:17:44 +0000 (GMT) Message-ID: <2440f8db6d5d528a0fd3e6556d7c8d1db78f9166.camel@us.ibm.com> Subject: Re: [PATCH ver 4] rs6000, add overloaded DFP quantize support From: Carl Love To: "Kewen.Lin" , cel@us.ibm.com Cc: Peter Bergner , Segher Boessenkool , David Edelsohn , GCC Patches Date: Tue, 29 Aug 2023 08:17:43 -0700 In-Reply-To: <3753051c-bc5c-ecdc-cfcc-621311b56d8f@linux.ibm.com> References: <7b79bbc4c465d22e565ec627ed379575bf9f7cf5.camel@us.ibm.com> <3753051c-bc5c-ecdc-cfcc-621311b56d8f@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: R4klsjd-Momg9ueHhTVU-wxmSYGCASwm X-Proofpoint-GUID: g2Vy4uopu4PmcccBcrkhvb_dwAM6N_KK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-29_13,2023-08-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 mlxlogscore=772 clxscore=1015 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2308290131 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Kewen: On Tue, 2023-08-29 at 16:54 +0800, Kewen.Lin wrote: > > The following functions require @option{-mhard-float}, > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr93448.c > > b/gcc/testsuite/gcc.target/powerpc/pr93448.c > > new file mode 100644 > > index 00000000000..f9c388585d7 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/powerpc/pr93448.c > > @@ -0,0 +1,200 @@ > > +/* { dg-do run } */ > > +/* { dg-require-effective-target dfp_hw} */ > > +/* { dg-require-effective-target has_arch_pwr6} */ > > Sorry, I didn't catch this in the previous reviews. > "dfp_hw" and "has_arch_pwr6" don't have the expected > space after, without the space, the checkings would > be useless and this case can fail. So they should be: > > /* { dg-require-effective-target dfp_hw } */ > /* { dg-require-effective-target has_arch_pwr6 } */ > > Okay for trunk with this fixed, thanks! OK, I take it the parsing of the lines by the test scripts will fail without the space since it can't parse it correctly. Thanks for letting me know. Here is the fixed up code. Note, I added the space before the "}" and removed the extra space before dfp_hw and has_arch_pwr6. get/powerpc/pr93448.c new file mode 100644 index 00000000000..6b800f8d63d --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr93448.c @@ -0,0 +1,200 @@ +/* { dg-do run } */ +/* { dg-require-effective-target dfp_hw } */ +/* { dg-require-effective-target has_arch_pwr6 } */ +/* { dg-options "-mhard-float -O2 -save-temps" } */ + +/* Test the decimal floating point quantize built-ins. */ I will go ahead and commit the patch. Thanks for all your help. Carl