From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3299D3858CDA for ; Mon, 17 Jun 2024 10:48:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3299D3858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3299D3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718621335; cv=none; b=RaZ3UZ/sn87VFqOqdM0EWtm6ZvmIH1RAOMNBwOOpwbiEMsxrxHmiwH4XlmnqIfia8Uv+4eXkPzWry1sU/6q39o4suZjLYXWoZIMmovyw9Nrw84pJjhMiOevVDrGgMSFZGTzualIo5FaGrwHFbP/5CnF1lN761eq3eP4bSLwUn8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718621335; c=relaxed/simple; bh=4175uDKm0vVc4ep+eUq8mMnUtOVsIxF/BZ+8PS/k0bM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=KBohL1l38Q19nZ0LWFZGuHoLaDCpu/jK2f8SktdZgZzePmrP8QLKWhJDBTbXK/kB1U7uGWdD/F2GRChj1mQAIZyQ1ZwRidssQxDG86tY1RbHrV9dQo0JnjVOLJVgdjWGzODRrTR9uubRm8LpJGmfD/fW+TVnb0iMdVCPkGupaNo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45H604l0008268 for ; Mon, 17 Jun 2024 06:07:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=G JVKEkvXU58F6adnHUKtl/WrT1Zb7DzemErJBi03kXU=; b=ZKYj+/CMFAZT1esxh l3lbfL2yxbuIThz10p+IXG0tnINJTQbTZ9q2Yu2oX9Z0QiCj7VzO0+9XZmA6mlMP 5hHzHfYhBjpzaIHpnBYCfMdkS/htOv/1SU1Z1MYRtM3L/P2U9nR4esGNfmQccps2 h2kUkAYDRSCbDiqHfhb2PWsbmUjSN8pMUCXRkfUHRzplZo5sFSQ1YbKbSkrQjppt 1X5goQyb1a8uezkZQNrGFjOatrRej+Y/uhzJn7yIuIIcXdhmMFN7uWqaeO2YVzxG 6wgcSHLFxsn9fYeKVxs1n8B79aYXg4KCHBeN00CU2yyfK+48/++jmQcDYm2HFzst tnq0w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ytffb00m0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 17 Jun 2024 06:07:41 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45H67eEb018081 for ; Mon, 17 Jun 2024 06:07:40 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ytffb00kw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 06:07:40 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45H4l2cX023963; Mon, 17 Jun 2024 06:07:39 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ysp9pqc64-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 06:07:39 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45H67ZER14811474 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Jun 2024 06:07:37 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48CEA2004B; Mon, 17 Jun 2024 06:07:35 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 219BC20040; Mon, 17 Jun 2024 06:07:34 +0000 (GMT) Received: from [9.200.55.24] (unknown [9.200.55.24]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 17 Jun 2024 06:07:33 +0000 (GMT) Message-ID: <2480cfc6-fe74-5a7b-ae3a-2ce30cd957a9@linux.ibm.com> Date: Mon, 17 Jun 2024 14:07:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 06/52] m2: Replace uses of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE Content-Language: en-US To: Gaius Mulley Cc: Joseph Myers , gcc-patches@gcc.gnu.org References: <1a669daea19f586636a7aba0dce9dd1627ce3459.1717134752.git.linkw@linux.ibm.com> <877cf3bha7.fsf@localhost> <1102e056-010b-045b-0c49-ad4804cfb2fa@linux.ibm.com> <87wmmqkdgk.fsf@localhost> From: "Kewen.Lin" In-Reply-To: <87wmmqkdgk.fsf@localhost> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: QdecbrUYm041TNLG51OvrrFutVHvEplw X-Proofpoint-ORIG-GUID: NshcFRxxTWBaCaYPbtVkkhG0OCMU-s2X X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-17_04,2024-06-14_03,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 adultscore=0 spamscore=0 mlxscore=0 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=775 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406170043 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2024/6/15 13:00, Gaius Mulley wrote: > "Kewen.Lin" writes: > >> Hi Gaius, >> >>>> static tree >>>> build_m2_short_real_node (void) >>>> { >>>> - tree c; >>>> - >>>> - /* Define `REAL'. */ >>>> - >>>> - c = make_node (REAL_TYPE); >>>> - TYPE_PRECISION (c) = FLOAT_TYPE_SIZE; >>>> - layout_type (c); >>>> - return c; >>>> + /* Define `SHORTREAL'. */ >>>> + layout_type (float_type_node); >>> >>> It looks that float_type_node, double_type_node, float128_type_node and >>> long_double_type_node have been called with layout_type when they are >>> being initialized in function build_common_tree_nodes, maybe we can just >>> assert their TYPE_SIZE. >> >> I just noticed that latest trunk still has {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE >> in gcc/m2 and realized that my comment above was misleading, sorry about that. >> It meant TYPE_SIZE (float_type_node) etc. instead of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE, >> as this patch series would like to get rid of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE. >> >> I adjusted them as below patch, does this look good to you? > > Hi Kewen, > > ah yes indeed, lgtm, Thanks Gaius! Pushed as r15-1362-g96fe23eb8a9eba. BR, Kewen