From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DA91E3882052 for ; Thu, 13 Jun 2024 15:24:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA91E3882052 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA91E3882052 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718292263; cv=none; b=MVyin+KF5PtQ7yT949UOGMGhIehFCIXIVrp0R0XWXhgr4LcTId1BLPR84c+C4q3135u9NfaJmeDFe5kd6NbyvXxIvgHONjYtMln8sBnEz8V0Dg6xthfNlI7rNBuc3/7Y6fVA6kU27gf3EhZCuQqLMXKkSmzqITxmmu/qcvxhDos= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718292263; c=relaxed/simple; bh=GQaxxjzogcAA8yKykq9iH5+YFftZJ9ZCHfJXiNfi18o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bAlLjRROtbAzb6zA1hevorfDw8XC7aAVn2OHTL8dAJvXPi3FirkgH7blmf02/xtUZghsQWEeQEZ067aR4IqDokGoBPDhq7Uz7E7Dzcb0l1q6fpT2C/bQsEvBY/2tGF+hpyvDtu+nXwl6wSDyW2wF1SBqqagEIDT9xql4ab4Tl8o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718292260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNiS6971ySXOP41ANKxCyCybZH/jd9QB7D3JH6LQf6E=; b=eySI8GQSXarHQ47oJ486F8+krtvF9WCkjfjPOmDN+ZdXaV1vs2FhaJlIdm7t8oQ5CV72fA ZO+wBzswVe1Kv3N2xrIUkJko9HXse3LRQAr5DnABovyxHU5PmX90KAJ8pXC24+32rVzCrw eyT6soYEk0VT+OaT1Ek/cUZp4FIX4o4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-VOW1fH4tMNGmrw8xdacO3w-1; Thu, 13 Jun 2024 11:24:19 -0400 X-MC-Unique: VOW1fH4tMNGmrw8xdacO3w-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6b07eccbaceso12215096d6.3 for ; Thu, 13 Jun 2024 08:24:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718292258; x=1718897058; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZNiS6971ySXOP41ANKxCyCybZH/jd9QB7D3JH6LQf6E=; b=XpnkjV5hh7IsBlxEfFKuIvazdtOyiR3v2DxLhG33dW4y/cQfQXZ9s/Vrms1CPoEsZB 99DOMLB75DcoUDePZ1DwqSgtED+Sh8/GGjBEyNOFL+ZCAjg2iflaDTXukasOAeeeMeBd WGDK1Mc6K52skP10cySqwYflEhfYsTfPC3uLcEsVEoDO0sZEXu0LMVM96zPvvJXfDtcz q3Z1bxWMCwa/yX266+E+fZEdvJ0VFjZdNdool2qZLo7PiXTPneEhNkDPnYjZ/fOYwn/i lsrYti+SLHrzF+gYgAyW2I1cHHhKFGp5Q0i2T8M/ZjuxjHM2LtlUqV4Qi31yRVbvJMGY CC9g== X-Gm-Message-State: AOJu0Yyvji3vkowyMd8XuOKkIiRsmD4tktSq8k3FLK2SlWeTMmbNL8dw mCsarI7atXh+J2ufYqnBMLoI06Nx+LO3TX+as0tT9aaDlsDQTA4wEWS2Ae0xljH+wRlyKGqDtF1 Na1SIzry4XnMsoh1SWbmBULIZlAthQcJT6KEYzT5lWI0FSBIv8Xd3xm8= X-Received: by 2002:a05:6214:5507:b0:6b0:6cdb:4975 with SMTP id 6a1803df08f44-6b190cec5bdmr49878866d6.13.1718292258579; Thu, 13 Jun 2024 08:24:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOZ/R0krmSk5k+labX1P5KlC64GGJJDRwE5N4k5gVvBC5s0wzkTEYqapurcrljWGJt96bk+w== X-Received: by 2002:a05:6214:5507:b0:6b0:6cdb:4975 with SMTP id 6a1803df08f44-6b190cec5bdmr49878616d6.13.1718292258060; Thu, 13 Jun 2024 08:24:18 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b2a5bf2422sm7835796d6.5.2024.06.13.08.24.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 08:24:15 -0700 (PDT) Message-ID: <2484ef76-bd42-4182-9b21-f2449fec1784@redhat.com> Date: Thu, 13 Jun 2024 11:24:13 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pushed] c++: module std and exception_ptr To: Patrick Palka Cc: gcc-patches@gcc.gnu.org References: <20240612203038.2524582-1-jason@redhat.com> <9452d759-d456-60fb-939e-3720d90b6eb1@idea> From: Jason Merrill In-Reply-To: <9452d759-d456-60fb-939e-3720d90b6eb1@idea> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/13/24 11:16, Patrick Palka wrote: > On Wed, 12 Jun 2024, Jason Merrill wrote: > >> exception_ptr.h contains >> >> namespace __exception_ptr >> { >> class exception_ptr; >> } >> using __exception_ptr::exception_ptr; >> >> so when module std tries to 'export using std::exception_ptr', it names >> another using-directive rather than the class directly, so __exception_ptr >> is never explicitly opened in module purview. > > FWIW PR100134 ICEd in the same way, and r13-3236-g9736a42e1fb8df > narrowly fixed this by setting DECL_MODULE_PURVIEW_P on the enclosing > namespace around the time we set the flag on the namespace-scope entity in > question. I wonder if it'd be preferable to do something similar here, > e.g. set DECL_MODULE_PURVIEW_P on the enclosing namespace in > do_nonmember_using_decl? Interesting thought, but I don't think so, as this is a workaround for the broader 114683 problem; we shouldn't actually be setting DECL_MODULE_PURVIEW_P on the class, either, only the using-declaration. The problem is that we don't currently represent the using in a way that we can set flags on specifically. Jason