From: Iain Sandoe <developer@sandoe-acoustics.co.uk>
To: Arnaud Charlet <charlet@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Mike Stump <mrs@gcc.gnu.org>
Subject: Re: [Patch, Ada, Darwin] Fix bootstrap issue on Darwin8.
Date: Mon, 05 Sep 2011 19:27:00 -0000 [thread overview]
Message-ID: <248AD3A8-8084-483D-B807-09C23D1ACDF6@sandoe-acoustics.co.uk> (raw)
In-Reply-To: <20110905190443.GC30902@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
Hi Arno,
On 5 Sep 2011, at 20:04, Arnaud Charlet wrote:
>> Darwin8 does not have _SC_NPROCESSORS_ONLN defined.
>
> Is Darwin8 still active/supported?
it works - and I test from time to time.
.. feedback from fink in the form of bug reports suggests that it is
still being used in the wild too.
In fact, the tortuous route I used to get to a working PPC ADA
bootstrap was via a native-X darwin 8 compiler built on linux ;-)
(Now I know the problem with the PPC bootstrap it's easier to do a
native X from i686-darwin, but I was debugging).
----
The policy we have adopted is not to break earlier Darwin if possible -
(bearing in mind that Darwin is volunteer-supported these days and we
have scant resources).
However, FWIW, It is possible to build 4.6 even on Darwin 7 with some
fiddling (odcctools) ...
[ However, I'm not going to nail my colors to the mast over this
one ;-) ]
> Not as submitted, you haven't provided a suitable changelog for
> review.
oops... apologies (and for the long lines in the other change logs)
... shouldn't type them directly into the mailer I suppose.
ada:
* adaint.c (__gnat_number_of_cpus): Don't try to check
_SC_NPROCESSORS_ONLN for early versions of Darwin.
> Also, when you repost your patch, can you please send a single
> version of
> the patch (either inline or as an attachment)? TIA.
The reason for duplication was that some people prefer one and some
the other ..
.. plus mailers sometimes mangle in-line patches;
OK for trunk/4.6?
Iain
[-- Attachment #2: 178554-darwin8-ada-boot-diff.txt --]
[-- Type: text/plain, Size: 685 bytes --]
Index: gcc/ada/adaint.c
===================================================================
--- gcc/ada/adaint.c (revision 178554)
+++ gcc/ada/adaint.c (working copy)
@@ -2460,7 +2460,10 @@ __gnat_number_of_cpus (void)
int cores = 1;
#if defined (linux) || defined (sun) || defined (AIX) \
- || (defined (__alpha__) && defined (_osf_)) || defined (__APPLE__)
+ || (defined (__alpha__) && defined (_osf_)) \
+ || (defined (__APPLE__) \
+ && defined (__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) \
+ && __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ >= 1050)
cores = (int) sysconf (_SC_NPROCESSORS_ONLN);
#elif (defined (__mips) && defined (__sgi))
[-- Attachment #3: Type: text/plain, Size: 3 bytes --]
next prev parent reply other threads:[~2011-09-05 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 18:51 Iain Sandoe
2011-09-05 19:05 ` Arnaud Charlet
2011-09-05 19:27 ` Iain Sandoe [this message]
2011-09-05 20:38 ` Jack Howarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248AD3A8-8084-483D-B807-09C23D1ACDF6@sandoe-acoustics.co.uk \
--to=developer@sandoe-acoustics.co.uk \
--cc=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mrs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).