From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-193505-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 15793 invoked by alias); 24 Apr 2007 15:17:51 -0000
Received: (qmail 15785 invoked by uid 22791); 24 Apr 2007 15:17:50 -0000
X-Spam-Check-By: sourceware.org
Received: from wr-out-0506.google.com (HELO wr-out-0506.google.com) (64.233.184.235)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Apr 2007 16:17:48 +0100
Received: by wr-out-0506.google.com with SMTP id 57so1791307wri         for <gcc-patches@gcc.gnu.org>; Tue, 24 Apr 2007 08:17:47 -0700 (PDT)
Received: by 10.114.58.1 with SMTP id g1mr3113929waa.1177427866533;         Tue, 24 Apr 2007 08:17:46 -0700 (PDT)
Received: by 10.115.15.10 with HTTP; Tue, 24 Apr 2007 08:17:46 -0700 (PDT)
Message-ID: <24b520d20704240817ic999bb3xb39855b50e7f85ea@mail.gmail.com>
Date: Tue, 24 Apr 2007 15:42:00 -0000
From: "Doug Gregor" <doug.gregor@gmail.com>
To: "=?ISO-8859-1?Q?Pedro_Lamar=E3o?=" <pedro.lamarao@mndfck.org>,  	"Nathan Sidwell" <nathan@codesourcery.com>
Subject: Re: C++0x Constructor Delegation take 2
Cc: gcc-patches@gcc.gnu.org
In-Reply-To: <461DBB2D.4010309@mndfck.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <461DBB2D.4010309@mndfck.org>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-04/txt/msg01592.txt.bz2

Hi Pedro,

I have a few small comments to make about this version of the patch.
Otherwise, it looks good to me. However, I don't have the ability to
approve it. Nathan, could you take a look?

Index: gcc/testsuite/g++.dg/cpp0x/dc_02.C
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- gcc/testsuite/g++.dg/cpp0x/dc_02.C	(revis=C3=A3o 0)
+++ gcc/testsuite/g++.dg/cpp0x/dc_02.C	(revis=C3=A3o 0)
@@ -0,0 +1,35 @@
+// { dg-do compile }
+// { dg-options --std=3Dgnu++0x }

I suggest using "-std=3Dc++0x", since delegating constructors are in the
C++0x Working Paper (we're not relying on extensions at all).

+/* Initialize current class with INIT, a TREE_LIST of
+   arguments for a target constructor. If TREE_LIST is void_type_node,
+   an empty initializer list was given.  */
+
+static void
+perform_target_ctor (tree init)

I suggest adding a comment stating that this routine implements the
delegating constructors feature of C++0x.

  - Doug