From: "Doug Gregor" <doug.gregor@gmail.com>
To: "Nathan Sidwell" <nathan@codesourcery.com>
Cc: "GCC Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: PING: C++0x decltype patch
Date: Fri, 27 Jul 2007 18:03:00 -0000 [thread overview]
Message-ID: <24b520d20707271039v5082931dp34abedc5122b58d3@mail.gmail.com> (raw)
In-Reply-To: <46AA2AB7.5050004@codesourcery.com>
On 7/27/07, Nathan Sidwell <nathan@codesourcery.com> wrote:
> Doug,
> > The first sorry(), for BIT_FIELD_REF, should be a gcc_unreachable; it
> > just can't happen here. The second "sorry" I'd like to keep... if we
> > get here, it means that I somehow missed a particular member-access
> > expression node. So, apologize to the user and when they report the
> > bug, we'll see what the expression code is to fix the bug. Perhaps
> > internal_error would be better?
>
> IMHO that's exactly what
> gcc_assert (TYPE_P (expr) || DECL_P (expr))
> is for :) sorry is for pieces we _know_ we've not implemented. Here we _think_
> we've covered all the cases, so an assert is appropriate.
Understood. I'll turn it into an assert.
- Doug
prev parent reply other threads:[~2007-07-27 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 19:31 Doug Gregor
2007-07-26 7:54 ` Paolo Carlini
2007-07-26 8:04 ` Paolo Carlini
2007-07-26 8:13 ` Andrew Pinski
2007-07-26 9:06 ` Paolo Carlini
2007-07-26 19:29 ` Nathan Sidwell
2007-07-27 17:11 ` Doug Gregor
2007-07-27 17:31 ` Nathan Sidwell
2007-07-27 18:03 ` Doug Gregor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24b520d20707271039v5082931dp34abedc5122b58d3@mail.gmail.com \
--to=doug.gregor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).