From: Tom de Vries <Tom_deVries@mentor.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Mike Stump <mikestump@comcast.net>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>
Subject: Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite
Date: Mon, 27 Mar 2017 13:11:00 -0000 [thread overview]
Message-ID: <24cdf777-4ac0-c6f8-b118-79696744be2d@mentor.com> (raw)
In-Reply-To: <yddy3vuc0j8.fsf@CeBiTec.Uni-Bielefeld.DE>
On 24/03/17 13:38, Rainer Orth wrote:
> Hi Tom,
>
>> On 23/03/17 18:25, Mike Stump wrote:
>>> On Mar 23, 2017, at 8:46 AM, Tom de Vries <Tom_deVries@mentor.com> wrote:
>>>> I've run the gcc testsuite for target nvptx-none and ran into "test for
>>>> excess errors" FAILs due to:
>>>> ...
>>>> sorry, unimplemented: target cannot support alloca.
>>> We'd encourage ports to support alloca. :-)
>>>
>>>> OK for trunk for stage1?
>>> Ok. Ok for release branches and trunk as well, if you want. I'd
>>> recommend trunk, if your port is meant to work and test out nicely in gcc
>>> 7.
>>>
>> Committed to trunk.
> seems you didn't properly test this patchset.
Sorry, indeed I just tested the non-alloca target, but forgot the alloca
target.
Thanks for cleaning up the mess.
- Tom
next prev parent reply other threads:[~2017-03-27 13:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 15:46 Tom de Vries
2017-03-23 16:24 ` Thomas Schwinge
2017-03-23 16:51 ` Tom de Vries
2017-03-23 17:45 ` Mike Stump
2017-03-24 7:46 ` Tom de Vries
2017-03-24 12:43 ` Rainer Orth
2017-03-24 12:44 ` Richard Biener
2017-03-24 12:53 ` Rainer Orth
2017-03-24 13:04 ` Rainer Orth
2017-03-24 17:45 ` Mike Stump
2017-03-27 14:14 ` Tom de Vries
[not found] ` <d453445e-54be-d3b5-cc27-d73bdbcc855d@mentor.com>
2017-04-26 12:40 ` Tom de Vries
2017-04-26 12:50 ` Jakub Jelinek
2017-04-27 9:03 ` Tom de Vries
2017-04-28 8:23 ` Tom de Vries
2017-04-28 14:31 ` Tom de Vries
2017-04-28 1:35 ` Tom de Vries
2017-04-28 16:28 ` Jeff Law
2017-03-27 13:11 ` Tom de Vries [this message]
2017-03-28 8:51 ` Thomas Schwinge
2017-03-28 8:57 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24cdf777-4ac0-c6f8-b118-79696744be2d@mentor.com \
--to=tom_devries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=rguenther@suse.de \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).