From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1F9EC38618BB for ; Mon, 13 Nov 2023 14:07:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F9EC38618BB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F9EC38618BB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884449; cv=none; b=RwPFdnnmHXac0nd4S1z7kteTgW8wQ+ht0f+H/9dUV61cXc310kBnyjFTQc7uz/Rr2/hGn2hY8dxnrzFTABa5N/k8hr5tSWM3LoweZULeEc0RRXmBreiys2juMgDCVcobhHNQ79xPb0L5vxE+KnEnHHXObNuSGagh/SN8TPhijI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884449; c=relaxed/simple; bh=Hk24qi/CKGoi+1UICnTPNWRBn/NFW9/hVybI2XJ8B9I=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=ZUNu4dimJYdSDX9XjJnvHLPUb6a3nh5ym/n4C/vzh8tcJfhr3I+Ypw61NOGSWu2B1IYtzyyX3HxNSCTIt7pzIsABjNjiiMXoEEN7e1jkgTaU4hTpWAaeDg/x4dywHrbY6b6fAjIlT2dDL/kO/9bg/MSdc1BcojMbYWjso4/PgOc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699884447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y6aDcs+097UkVlJW7xE4eZkqIm/pa82hoGdgreO1RtQ=; b=XYdZGyy1CjY/3WqXbKiWr+k0xOXVoDR8zPJLc5r1fHgK6KkxIrgU1PB54QK5bHpzOxA/NH j+QWte4bMq1k0h4Ys4/LAZKhJQkwxHbX8OXhX2cGdKqk/MvMvkFRFB5VWzr/yLdcvUubyE LjTtua/cuhA2o0WpYvgDHOLXMn2GbXs= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-n2t5DkJkMfKZqCOUQN0jPA-1; Mon, 13 Nov 2023 09:07:26 -0500 X-MC-Unique: n2t5DkJkMfKZqCOUQN0jPA-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-58a5860c88fso361936eaf.0 for ; Mon, 13 Nov 2023 06:07:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699884445; x=1700489245; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Y6aDcs+097UkVlJW7xE4eZkqIm/pa82hoGdgreO1RtQ=; b=Pv8nbqq12Qyf6BwzwWPZOxNVdKvPiwiKaSKxnSKR+9VDw2akhXp7aOlE7U+RtjpL+S NueCjQt4Sc0fboeASw4i39Bb6/5NASbH/fy2oxrDlwTYdkZUcOjtQ7PCM6WiZGGLd8RV 4d89AAQnqMUD2zTBPD5VQoUXr8X4amaPDXk8NDm6rAfYxLLlmjTp17PblbZPI9usGc01 dyRprfMxN2MYsxNl/zs4lzEQKYrrzKedSrrIkNNuKYvVghjCK9TeHcw1T4SY+vBf8+uR iQW7f+UxEHMMOejngv8To0625TJngeVgeMSyBfjaEQG+vI9bpjVALT48oWuUP7Q1R0zs dvSw== X-Gm-Message-State: AOJu0Yw6YTDhKmaSvM7pP0TJ7V+M98Zc5f9mKUWN1+vDJKgXKQuh2gwZ zGTvrCiqS2mamB6z2+SwSiRWivVOOrTYA4lx+aCU/LO4IV3/qCbrk1vrXke2ajsvCj1ruQzjBXh dI2MDp5xkm/hFT8S6v/+0tm2YCA== X-Received: by 2002:a05:6870:5310:b0:1ea:7f54:77af with SMTP id j16-20020a056870531000b001ea7f5477afmr10142362oan.10.1699884445533; Mon, 13 Nov 2023 06:07:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyeZCNHCny3vimfmMwEeo+mEapcFwX2JWpUJC0jkMy8XwQdRkkSbykj95erIXUtQu+0BlaKg== X-Received: by 2002:a05:6870:5310:b0:1ea:7f54:77af with SMTP id j16-20020a056870531000b001ea7f5477afmr10142339oan.10.1699884445223; Mon, 13 Nov 2023 06:07:25 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id h12-20020ac8568c000000b00421b14f7e7csm1949310qta.48.2023.11.13.06.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 06:07:24 -0800 (PST) Message-ID: <24d0411f5e8494cf3c6b58bd1b259bf07fcfa858.camel@redhat.com> Subject: Re: [PATCH 2/3] Add generated .opt.urls files From: David Malcolm To: Marc =?ISO-8859-1?Q?Poulhi=E8s?= Cc: Joseph Myers , gcc-patches@gcc.gnu.org Date: Mon, 13 Nov 2023 09:07:23 -0500 In-Reply-To: <8734x9aj3m.fsf@adacore.com> References: <20231110214246.3087291-1-dmalcolm@redhat.com> <20231110214246.3087291-3-dmalcolm@redhat.com> <8734x9aj3m.fsf@adacore.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-11-13 at 14:11 +0100, Marc Poulhi=C3=A8s wrote: >=20 > David Malcolm writes: >=20 > > gcc/ada/ChangeLog: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* gcc-interface/lang.op= t.urls: New file, autogenerated by > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0regenerate-opt-urls.py. >=20 >=20 > > diff --git a/gcc/ada/gcc-interface/lang.opt.urls b/gcc/ada/gcc- > > interface/lang.opt.urls > > new file mode 100644 > > index 000000000000..e24210bcb12a > > --- /dev/null > > +++ b/gcc/ada/gcc-interface/lang.opt.urls > > @@ -0,0 +1,28 @@ > > +; Autogenerated by regenerate-opt-urls.py from gcc/ada/gcc- > > interface/lang.opt and generated HTML > > + > > +I > > +UrlSuffix(gcc/Directory-Options.html#index-I) > > + > > +; skipping 'Wall' due to multiple URLs: > > +;=C2=A0=C2=A0 duplicate: 'gcc/Standard-Libraries.html#index-Wall-1' > > +;=C2=A0=C2=A0 duplicate: 'gcc/Warning-Options.html#index-Wall' > > + > > +nostdinc > > +UrlSuffix(gcc/Directory-Options.html#index-nostdinc) > > + > > +nostdlib > > +UrlSuffix(gcc/Link-Options.html#index-nostdlib) > > + > > +; skipping 'fshort-enums' due to multiple URLs: > > +;=C2=A0=C2=A0 duplicate: 'gcc/Code-Gen-Options.html#index-fshort-enums= ' > > +;=C2=A0=C2=A0 duplicate: 'gcc/Non-bugs.html#index-fshort-enums-3' > > +;=C2=A0=C2=A0 duplicate: 'gcc/Structures-unions-enumerations-and-bit-f= ields- > > implementation.html#index-fshort-enums-1' > > + > > +; skipping 'fsigned-char' due to multiple URLs: > > +;=C2=A0=C2=A0 duplicate: 'gcc/C-Dialect-Options.html#index-fsigned-cha= r' > > +;=C2=A0=C2=A0 duplicate: 'gcc/Characters-implementation.html#index-fsi= gned- > > char-1' > > + > > +; skipping 'funsigned-char' due to multiple URLs: > > +;=C2=A0=C2=A0 duplicate: 'gcc/C-Dialect-Options.html#index-funsigned-c= har' > > +;=C2=A0=C2=A0 duplicate: 'gcc/Characters-implementation.html#index- > > funsigned-char-1' >=20 > Hello David, >=20 > This looks very nice, thanks! >=20 > I wonder why the Ada frontend only gets I, nostdinc and nostdlib > URLified to the common gcc doc. >=20 > Is it possible that your doc scrapper doesn't match the option in the > Ada doc? We are documenting nostdlib, nostdinc and I, so I would also > expect a "multiple URLs" for these. The new regenerate-opt-urls.py script only parsed buildir/gcc/HTML/gcc-14.0.0/gcc/Option-Index.html looking for anchors for options via a regex. Looking at my build, I don't see any generated Ada HTML docs, so maybe I messed this up? Does the generated HTML from the generated Ada texinfo go somewhere else? (and, in particular, does it have its own index?) Perhaps this script could also deal directly with Sphinx-generated HTML? > We are generating the texinfo files > from sphinx, so maybe we could adjust the script to also match what > the > sphinx generator produces? It *might* be as simple as pointing it at the option index for the generated HTML for Ada. Though as Iain's email points out, there may be some issues with per- language URLs for options that my approach doesn't quite handle yet. Dave