From: Matthias Klose <doko@ubuntu.com>
To: Tobias Burnus <tobias@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
Richard Biener <rguenther@suse.de>
Subject: Re: [Patch] offload-defaulted: Config option to silently ignore uninstalled offload compilers
Date: Wed, 28 Apr 2021 16:13:48 +0200 [thread overview]
Message-ID: <251870a9-85e8-b69b-2f94-841f7548c3ba@ubuntu.com> (raw)
In-Reply-To: <15f34348-0053-2f31-0603-fd0eefa33897@codesourcery.com>
On 4/27/21 12:22 PM, Tobias Burnus wrote:
> This is based on Jakub's patch* which is used with many distributions – and is has
> to be maintained by all of them; otherwise issues like lp #1878760 might creep in,
> as discussed in #gcc yesterday. - As I am a huge fan of reducing code duplication
> and local patches, I propose to add it to GCC proper behind a configure flag.
>
> The patch idea is: offloading support is configured for one or multiple offload
> devices
> but compilation silently ignores a target if its offload compiler is not found at
> compile time and also dlopen errors of the associated libgomp plugin is also
> silently ignored such that also the system where the program is run do not show
> a run-time error.
>
> This makes a lot of sense for distribution compilers – as it permits to configure
> GCC to support offloading to one/multiple offload targets, but the actual
> offload compiler and the run-time support can be put into separate, optional
> packages.
>
> (When -foffload=$TARGET is specified explicitly, it still gives
> an error if the offload compiler is not installed; this does not not affect the
> libgomp/run-time side.)
>
> However, for nondistro builds, compilers are usually installed "as is" and not
> split into different packages – thus, compilation or run-time issues should give
> an error.
>
> Hence, the distro behaviour is only active when configured with
> --enable-offload-defaulted.
>
> Comments? OK for mainline?
please document that option in gcc/doc/install.texi.
Matthias
next prev parent reply other threads:[~2021-04-28 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 10:22 Tobias Burnus
2021-04-28 14:05 ` Jakub Jelinek
2021-04-28 14:13 ` Matthias Klose [this message]
2021-04-28 16:56 ` Tobias Burnus
2021-04-28 16:59 ` Matthias Klose
2021-04-28 17:02 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=251870a9-85e8-b69b-2f94-841f7548c3ba@ubuntu.com \
--to=doko@ubuntu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).