* [PATCH] Decrease hash-table-verification-limit from 100 to 10.
@ 2019-06-19 13:15 Martin Liška
2019-06-19 15:54 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Martin Liška @ 2019-06-19 13:15 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
Hi.
The patch is about decrease of verification limit. I collected following statistics:
godot WPA:
hash-table-verification-limit=0: 66s
hash-table-verification-limit=10: 69s
hash-table-verification-limit=100: 94s
make all runtime libraries in GCC for --disable-bootstrap --disable-libsanitizer --disable-multilib
=0: 127s (17m30s user time)
=10: 130s (18m17s user time)
=100: 150s (20m37s user time)
That's why I'm suggesting default equal to 10. Moreover as items are rehashed during a hash table
growth we always compare different items.
Ready for trunk?
Thanks,
Martin
gcc/ChangeLog:
2019-06-19 Martin Liska <mliska@suse.cz>
* params.def (PARAM_HASH_TABLE_VERIFICATION_LIMIT): Decrease
to 10.
---
gcc/params.def | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[-- Attachment #2: 0001-Decrease-hash-table-verification-limit-from-100-to-1.patch --]
[-- Type: text/x-patch, Size: 369 bytes --]
diff --git a/gcc/params.def b/gcc/params.def
index 0db60951413..4567c17ba60 100644
--- a/gcc/params.def
+++ b/gcc/params.def
@@ -1435,7 +1435,7 @@ DEFPARAM(PARAM_HASH_TABLE_VERIFICATION_LIMIT,
"hash-table-verification-limit",
"The number of elements for which hash table verification is done for "
"each searched element.",
- 100, 0, 0)
+ 10, 0, 0)
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Decrease hash-table-verification-limit from 100 to 10.
2019-06-19 13:15 [PATCH] Decrease hash-table-verification-limit from 100 to 10 Martin Liška
@ 2019-06-19 15:54 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2019-06-19 15:54 UTC (permalink / raw)
To: Martin Liška, gcc-patches
On 6/19/19 7:15 AM, Martin Liška wrote:
> Hi.
>
> The patch is about decrease of verification limit. I collected following statistics:
>
> godot WPA:
>
> hash-table-verification-limit=0: 66s
> hash-table-verification-limit=10: 69s
> hash-table-verification-limit=100: 94s
>
> make all runtime libraries in GCC for --disable-bootstrap --disable-libsanitizer --disable-multilib
>
> =0: 127s (17m30s user time)
> =10: 130s (18m17s user time)
> =100: 150s (20m37s user time)
>
> That's why I'm suggesting default equal to 10. Moreover as items are rehashed during a hash table
> growth we always compare different items.
>
> Ready for trunk?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> 2019-06-19 Martin Liska <mliska@suse.cz>
>
> * params.def (PARAM_HASH_TABLE_VERIFICATION_LIMIT): Decrease
> to 10.
OK
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-19 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 13:15 [PATCH] Decrease hash-table-verification-limit from 100 to 10 Martin Liška
2019-06-19 15:54 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).