From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 6DCAA3953CFA for ; Mon, 31 Aug 2020 15:56:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6DCAA3953CFA Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07VFWcCk050085; Mon, 31 Aug 2020 11:56:23 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 338yrv84j8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Aug 2020 11:56:23 -0400 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 07VFWm8P050621; Mon, 31 Aug 2020 11:56:23 -0400 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 338yrv84hs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Aug 2020 11:56:22 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07VFr3M8030300; Mon, 31 Aug 2020 15:56:21 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma05wdc.us.ibm.com with ESMTP id 337en91646-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Aug 2020 15:56:21 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07VFuLCS53281132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 15:56:21 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6157028059; Mon, 31 Aug 2020 15:56:21 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B092E28058; Mon, 31 Aug 2020 15:56:20 +0000 (GMT) Received: from sig-9-65-236-202.ibm.com (unknown [9.65.236.202]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 31 Aug 2020 15:56:20 +0000 (GMT) Message-ID: <251f8345c49536a67d3bd71604b7a7711de9694c.camel@vnet.ibm.com> Subject: Re: [PATCH] rs6000, vec_popcntd is improperly defined in altivec.h From: will schmidt To: Carl Love , Segher Boessenkool , Peter Bergner Cc: dje.gcc@gmail.com, gcc-patches@gcc.gnu.org, Bill Schmidt Date: Mon, 31 Aug 2020 10:56:20 -0500 In-Reply-To: <654f0f9d97d64e963eea806566963146c64615a6.camel@us.ibm.com> References: <654f0f9d97d64e963eea806566963146c64615a6.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-8.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-31_07:2020-08-31, 2020-08-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 mlxlogscore=770 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310091 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2020 15:56:25 -0000 On Fri, 2020-08-28 at 08:08 -0700, Carl Love wrote: > GCC maintainers: > Hi, > The defines for vec_popcnt, bvec_popcnth, vec_popcntw, vec_popcntd in s/bvec/vec/ > gcc/config/rs6000/altivec.h are not listed in the Power 64-Bi ELF V2 > ABI specification revision 1.4, May 10, 2017. They are not used by > any > of the regression tests. They also do not work as reported in: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85830 > Can probably replace that URL with a reference to "PR 85830". > The following patch removes the unsupported defines for the builtin > functions. > > The patch has been tested on > > powerpc64le-unknown-linux-gnu (Power 9 LE > > with no regression errors. > > Please let me know if this patch is acceptable for mainline. > > Carl Love > > ------------------------------------------------------ > vec_popcntd is improperly defined in altivec.h ^ stray line ? > > gcc/ChangeLog > > 2020-08-27 Carl Love > > PR target/85830 > * config/rs6000/altivec.h (vec_popcntub, vec_popcntuh, > vec_popcntuw, > vec_popcntud): Remove defines. > --- > gcc/config/rs6000/altivec.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/gcc/config/rs6000/altivec.h > b/gcc/config/rs6000/altivec.h > index bf2240f16a2..8a2dcda0144 100644 > --- a/gcc/config/rs6000/altivec.h > +++ b/gcc/config/rs6000/altivec.h > @@ -407,10 +407,6 @@ > #define vec_vpopcnth __builtin_vec_vpopcnth > #define vec_vpopcntw __builtin_vec_vpopcntw > #define vec_popcnt __builtin_vec_vpopcntu > -#define vec_popcntb __builtin_vec_vpopcntub > -#define vec_popcnth __builtin_vec_vpopcntuh > -#define vec_popcntw __builtin_vec_vpopcntuw > -#define vec_popcntd __builtin_vec_vpopcntud That looks OK within this context. Are there any existing tests that use these named variations? Thanks, -Will > #define vec_vrld __builtin_vec_vrld > #define vec_vsld __builtin_vec_vsld > #define vec_vsrad __builtin_vec_vsrad