From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Richard.Earnshaw@foss.arm.com>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by sourceware.org (Postfix) with ESMTP id 9FE65385841D
 for <gcc-patches@gcc.gnu.org>; Tue,  7 Dec 2021 14:16:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FE65385841D
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A3011042;
 Tue,  7 Dec 2021 06:16:38 -0800 (PST)
Received: from [10.57.0.71] (unknown [10.57.0.71])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B027F3F5A1;
 Tue,  7 Dec 2021 06:16:37 -0800 (PST)
Subject: Re: [Patch 4/8, Arm. GCC] Add testsuite library support for PACBTI
 target. [Was RE: [Patch 3/7, Arm, GCC] Add testsuite library support for
 PACBTI target.]
To: Tejas Belagod <Tejas.Belagod@arm.com>,
 Richard Earnshaw <Richard.Earnshaw@arm.com>,
 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
References: <PAXPR08MB7075D4CACC81C24CF2A14893EA869@PAXPR08MB7075.eurprd08.prod.outlook.com>
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
Message-ID: <252000cf-e0a5-aa17-d415-14e8c1821ec1@foss.arm.com>
Date: Tue, 7 Dec 2021 14:16:36 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <PAXPR08MB7075D4CACC81C24CF2A14893EA869@PAXPR08MB7075.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-3491.0 required=5.0 tests=BAYES_00, BODY_8BITS,
 KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE,
 SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Dec 2021 14:16:40 -0000



On 28/10/2021 12:42, Tejas Belagod via Gcc-patches wrote:
> 
> 
>> -----Original Message-----
>> From: Richard Earnshaw <Richard.Earnshaw@arm.com>
>> Sent: Monday, October 11, 2021 2:38 PM
>> To: Tejas Belagod <Tejas.Belagod@arm.com>; gcc-patches@gcc.gnu.org
>> Subject: Re: [Patch 3/7, Arm, GCC] Add testsuite library support for PACBTI
>> target.
>>
>> On 11/10/2021 14:36, Richard Earnshaw via Gcc-patches wrote:
>>> On 08/10/2021 13:17, Tejas Belagod via Gcc-patches wrote:
>>>> Hi,
>>>>
>>>> Add targeting-checking entities for PACBTI in testsuite framework.
>>>>
>>>> Tested on arm-none-eabi. OK for trunk?
>>>>
>>>> 2021-10-04  Tejas Belagod  <tbelagod@arm.com>
>>>>
>>>> gcc/ChangeLog:
>>>>
>>>>      * testsuite/lib/target-supports.exp
>>>>      (check_effective_target_arm_pacbti_hw): New.
>>>>
>>>
>>> OK.
>>>
>>> R.
>>
>> Oh, wait!  Not OK.  Needs documentation in sourcebuild.texi.
>>
> 
> Thanks for the reviews.
> 
> Add targeting-checking entities for PACBTI in testsuite
> framework.
> 
> 2021-10-25  Tejas Belagod  <tbelagod@arm.com>
> 
> gcc/ChangeLog:
> 
> 	* testsuite/lib/target-supports.exp:
> 	(check_effective_target_arm_pacbti_hw): New.
> 	* doc/sourcebuild.texi: Document arm_pacbti_hw.
> 

The testsuite has its own changelog file.

> Tested the following configurations, OK for trunk?
> 
> -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft
> -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp
> mcmodel=small and tiny
> aarch64-none-linux-gnu native test and bootstrap
> 
> Thanks,
> Tejas.
> 

Otherwise, OK.

R.