From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <amonakov@ispras.ru>
Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84])
 by sourceware.org (Postfix) with ESMTPS id 26D8B3858010
 for <gcc-patches@gcc.gnu.org>; Mon, 23 May 2022 10:56:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26D8B3858010
Received: from [10.10.3.121] (unknown [10.10.3.121])
 by mail.ispras.ru (Postfix) with ESMTPS id 6FD6440D403D;
 Mon, 23 May 2022 10:56:32 +0000 (UTC)
Date: Mon, 23 May 2022 13:56:32 +0300 (MSK)
From: Alexander Monakov <amonakov@ispras.ru>
To: Jan Hubicka <hubicka@kam.mff.cuni.cz>
cc: Martin Jambor <mjambor@suse.cz>, Artem Klimov <jakmobius@gmail.com>, 
 gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] ipa-visibility: Optimize TLS access [PR99619]
In-Reply-To: <4e7a3a6a-b437-7ddc-7acb-febcef942f4f@ispras.ru>
Message-ID: <2533523c-2fa4-806a-6eeb-bda9813912b9@ispras.ru>
References: <20220417185113.25780-1-jakmobius@gmail.com>
 <ri6zgjzj4z8.fsf@suse.cz> <381c469c-516e-808f-f811-314eddaf2ba9@ispras.ru>
 <5e8789c-7394-7521-33ae-70375d9a28@ispras.ru>
 <YnlFuYf4Ulnk35Lz@kam.mff.cuni.cz>
 <4e7a3a6a-b437-7ddc-7acb-febcef942f4f@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 May 2022 10:56:38 -0000

On Mon, 16 May 2022, Alexander Monakov wrote:

> On Mon, 9 May 2022, Jan Hubicka wrote:
> 
> > > On second thought, it might be better to keep the assert, and place the loop
> > > under 'if (optimize)'?
> > 
> > The problem is that at IPA level it does not make sense to check
> > optimize flag as it is function specific.  (shlib is OK to check it
> > anywhere since it is global.)
> > 
> > So I think we really want to run the code only at the WPA time
> > (symtab_state>=IPA_SSA) and we want to see what is optimization flag of
> > those function referring the variable since that is what decided codegen
> > we will produce.
> 
> Perhaps I misunderstood the issue. Are you saying that there might be no -O
> option on lto1 command line, because lto1 is supposed to take optimization
> level from function summaries, but during pass_ipa_whole_program_visibility
> there's no "current function" so 'optimize' is at its default value (zero)?
> 
> And the solution is to iterate over referring functions to see if at least
> one of them satisfies 'opt_for_fn (decl, optimize) > 0'?

Do you want to see a patch implementing the above solution?

Alexander