From: Jeff Law <jeffreyalaw@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>, gcc-patches@gcc.gnu.org
Cc: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH] testsuite: require libc sym for -shared
Date: Wed, 24 Jan 2024 10:46:57 -0700 [thread overview]
Message-ID: <25995833-2eaa-4d5d-8e79-d5282e8e71e3@gmail.com> (raw)
In-Reply-To: <or4jf4jzba.fsf@lxoliva.fsfla.org>
On 1/23/24 00:15, Alexandre Oliva wrote:
>
> Targets whose binutils support -shared, but that don't have a shared
> libc, and that can't add PDC (non-PIC) to shared libraries, may
> succeed at the effective target test for -shared, because it brings
> nothing from libc, but tests that rely on -shared and that use bits
> from libc, such as g++.dg/lto/pr108772, fail despite requiring the
> shared effective target.
>
> Extend the effective target test to bring malloc() from libc, that's
> likely to be present in libc and bring a substantial amount of code if
> no shared libc is available.
>
> Regstrapped on x86_64-linux-gnu, also tested on aarch64-elf with gcc-13,
> where the problem was observed. Ok to install?
>
>
> for gcc/testsuite/ChangeLog
>
> * lib/target-supports.exp (check_effective_target_shared):
> Check for a static-only libc.
OK
jeff
prev parent reply other threads:[~2024-01-24 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 7:15 Alexandre Oliva
2024-01-24 17:46 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25995833-2eaa-4d5d-8e79-d5282e8e71e3@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=oliva@adacore.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).