From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id F0CE43858D38 for ; Wed, 24 Jan 2024 17:46:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0CE43858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F0CE43858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706118421; cv=none; b=sQ0bQp2FP63H7hAzu0BFnV5mJWQAaeKm1dHGCt8smy72Idu6kKm7uPhvBr9PUHP4mcLmKGzdLzFJi3yftZQ1iPGdNyLiUOGQHVc+Cb7JMy9i4UH2WX39QT41yGueQYhXwbQstPybQCZdkcH/Vpyd2ASTbqgPXDwhPOGFZZioxUQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706118421; c=relaxed/simple; bh=jl134tWoOYvZxrFyEq/lFgFZKZ4xm7GAZJkuCMaW4eQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pwPHNWZuAouZiFJlhgRJTx/vyCYPa0HJs9kp3+MKTRF7PZoB6PP3Gr3ykALx41+8MJGNX1P3WdtDC01+6zyIvgURB1mGlnN3wxNbWYIrYpLCgjmF17bAiiw5RaoD4sBYDvc53fdRH9rJfMJtTHPCA90KFUx5uIqI0IZT6VREYNE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7bee87b2f5eso180934339f.3 for ; Wed, 24 Jan 2024 09:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706118419; x=1706723219; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rn8IWKq7BVkdpJCii8D4vbA7KTY8rMokiTYve0aDelo=; b=bZwhgvLWVzvtv8l+uZ0mSrbFZJp677FllIeoPxmqoVRCfwwCB5clGNa0QmKicfytQZ QTDflo7vEFdlJNhUY66f10cpCrUw83UFZznt3sQetTs1J7hZJo0WnrU8Gf72MuES+y19 i0bi4gNM9EChynXEE9K7y53J660dHEb5e0F+LgxDy2pzooqqGRr9DcHYH2j/hHBUwVgc nAjAfLCK2/Vj3rLHvy3NUll4+9aC4O9Gen9WVnR0Oniq457/KNkau+5N2lWJe7qXikp4 ikq6qkDKe039gFVUoDbQe05KabatKTJnaPopEFpZjvJzwEvwhzuLxf5Flv3OfBOIaEer pqsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706118419; x=1706723219; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rn8IWKq7BVkdpJCii8D4vbA7KTY8rMokiTYve0aDelo=; b=Nbnb0uTQQD1l5bemNDQ5nPtpQBpYaEJsUExHjQ46PLapnpdNOOn32g45fQ4xiQkcAx HZD/HAr0vwOxytEvcH1xqXMztTZJ/T67FmXYyR1A1z7BDo92Slm6GEFKuLzcrg+Qz5Tr oaJqL09JZMAD2GYAh6lq2mTuXuVaa6ILCCkqonNmrwVU/rFJNs2AwtvF/x5c90toFzSA /OnOqy+KVncnFZMV9SbyWyui2CQPNxOUWlMPUyp8yemHMIH7NmcwCsLQwKn2OCwVQuOw JJEDbP95LxZ1azq+DDcve3WUxMaI2K9Tf65To+bZCsIHAkA+qyx/+Aqwj0hGI/j8Nh2O Vfvw== X-Gm-Message-State: AOJu0YyILUnQLxe3VFoetj9bmogyYjS+Wra4TSy1fjxn1hbttZd7GSwA uh4RlQAElzcagKAnWl0Ma4oz1fwojfpq5A2ZPtkMnhF20hK/HldZ X-Google-Smtp-Source: AGHT+IGRUYLRijD4kiDG3Kucuw7LyzwMQ5y0+FDUDtu53MrBqWvPC/0AsVcgpXxsTPKgkYWWNqHZsw== X-Received: by 2002:a5e:8703:0:b0:7bc:25d7:eb8a with SMTP id y3-20020a5e8703000000b007bc25d7eb8amr2420343ioj.29.1706118419160; Wed, 24 Jan 2024 09:46:59 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id y6-20020a6bc806000000b007bf46975136sm5924981iof.54.2024.01.24.09.46.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 09:46:58 -0800 (PST) Message-ID: <25995833-2eaa-4d5d-8e79-d5282e8e71e3@gmail.com> Date: Wed, 24 Jan 2024 10:46:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] testsuite: require libc sym for -shared Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org Cc: Rainer Orth , Mike Stump References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/23/24 00:15, Alexandre Oliva wrote: > > Targets whose binutils support -shared, but that don't have a shared > libc, and that can't add PDC (non-PIC) to shared libraries, may > succeed at the effective target test for -shared, because it brings > nothing from libc, but tests that rely on -shared and that use bits > from libc, such as g++.dg/lto/pr108772, fail despite requiring the > shared effective target. > > Extend the effective target test to bring malloc() from libc, that's > likely to be present in libc and bring a substantial amount of code if > no shared libc is available. > > Regstrapped on x86_64-linux-gnu, also tested on aarch64-elf with gcc-13, > where the problem was observed. Ok to install? > > > for gcc/testsuite/ChangeLog > > * lib/target-supports.exp (check_effective_target_shared): > Check for a static-only libc. OK jeff