From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id D83753858C52 for ; Wed, 10 Jan 2024 09:13:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D83753858C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D83753858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704877993; cv=none; b=M1lqzQ6eoxgEmlQNHyDJPEamlYCKIOBN21279FTXMzdSyEKwgh/D1bC8ecpTb0CN++8KdecjypXZz9VAZB9U12Gsuf4wMjM/Lki1ZWoBSc1aBFiYXuuCfED23BBQ01ZrTaYBUZfJWi+qvUNw/GQBRz8NWdaPvvxdRb09iCy9ifU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704877993; c=relaxed/simple; bh=TY7DYt6NvFRleGqc2W6M2TrawVk7wbbXkcYtHklWAxg=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=WRvYe6DRp2NfdoiInVXUJz6Rjj/Nh+pu+f/Jjm1GUfGsb9I5bmHTyeOHBtNO9AoLiun884cTcWztce5bKWQKUOfl7Hw5qmcJwvt1eR/m6OTtYuPfvbNJpdGYC+q8JDYyL6UQAhK1vV/hEacBATmdkEY+1tgeOJY6mFYXXP2+AqE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40e552dfa5dso7308785e9.1 for ; Wed, 10 Jan 2024 01:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1704877989; x=1705482789; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FwnLEW7tCjSSprW1mupHDVORMc5zAcPuq477kq3INhg=; b=EZ+SCxpakffUhZFJFVJtSICqFUZ5OphAiFhyZha2iXAm0Yv3AHQaGl+eWiZULfsK2G H9F+o3hFh44VTd4HMU/UEG+rsG66o6WGJGLbNaQoPAaEAIFIjlce3WPf0aJNJpwDO8BM +sz9kOnYNGuxsLt9pqo06wNmAD0eW8ttlrg/jVTY79YcLdtSfHjxHiGpWaPDcNQNpfcc v7Xbbqd0JZMVdt9x0bjJ5O+NP4BC9qtxyKCBoLqxZHjsvDgqFPi+AO+K0MeqfMZMu5U4 rVE1Efcmw0injB3V7txrBUrfFMJNrWEFDl1SCy3w58DlCGMHAq9P9kk8Lq4j8BmJ29Qp ES8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704877989; x=1705482789; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FwnLEW7tCjSSprW1mupHDVORMc5zAcPuq477kq3INhg=; b=do+W/tstDoZE4q5qi0YzecZw9c1oV0OnVCuS7vmMflXj638jruCooF9Rpg588IPmQj 8A70uRKL7IjdYGuKHO3c4lVyBH+LnDRzPOblh03szm9m8nnMUh798y2bCB35QAR5lN92 FW2SuuhvwhyovdXG7GophV3swBLPATEvxbAEf3Ho7dk5C6kptx8GDlVpd7wl76QxFF5I WHMVsLB9OaoP34/vzBaw2sSRCAmBoksuMC9bu7KkN0jyYoEWuegLAIWJB4F4DGI6uSLh vjGEWd3qbkIzt0OxFqnpwrkorqzemeUoif1uFnNdu0hl9HxEdx5u+LD9YkhVDpUJ0GAJ CxmA== X-Gm-Message-State: AOJu0YxTv0E8Je8o7lXpct7BZSo9WBA8PYMBYDLfqPrP2yRul8ZMGCVy 9DHrD9tbNYv58TLHljz+498= X-Google-Smtp-Source: AGHT+IFMcfGaMkJ6zlRKq6NcwuSuNPNHzNEx7RAKVFWtB0u4Pv/u0+SZSb2UpnXWQF9op2Q1OG7r2Q== X-Received: by 2002:a05:600c:3b91:b0:40e:52f1:7eea with SMTP id n17-20020a05600c3b9100b0040e52f17eeamr401880wms.30.1704877989488; Wed, 10 Jan 2024 01:13:09 -0800 (PST) Received: from smtpclient.apple (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id s7-20020a05600c45c700b0040d8ff79fd8sm1460451wmo.7.2024.01.10.01.13.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jan 2024 01:13:09 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [RFC] Either fix or disable SME feature for `aarch64-w64-mingw32` target? From: Iain Sandoe In-Reply-To: <46A5B718-2336-4F76-9E21-5DB9C40DF067@googlemail.com> Date: Wed, 10 Jan 2024 09:13:08 +0000 Cc: GCC Patches , "pinskia@gmail.com" , Richard Sandiford Content-Transfer-Encoding: quoted-printable Message-Id: <25B526B5-5C40-4F35-B412-E9CB8E2FCC95@googlemail.com> References: <452e47e2-7222-46b2-bec1-cb1df812b3ea@gmail.com> <46A5B718-2336-4F76-9E21-5DB9C40DF067@googlemail.com> To: Jonathan Yong <10walls@gmail.com>, Radek Barton X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 10 Jan 2024, at 09:02, Iain Sandoe wrote: >> On 10 Jan 2024, at 08:49, Jonathan Yong <10walls@gmail.com> wrote: >>=20 >> On 1/9/24 19:37, Radek Barton wrote: >>> Hello. >>> I forgot to add the target maintainers to the CC. My apologies for = that. >>> Furthermore, I am adding also relevant changes in = `libgcc/config/aarch64/lse.S` file to the patch. Originally we wanted to = submit those changes separately but after the feedback from Andrew = Pinski, it makes sense to add them here. I needed to rename `HIDDEN`, = `TYPE`, and `SIZE` macros to `HIDDEN_PO`, `TYPE_PO`, and `SIZE_PO` = (pseudo-op) because there is a collision with other macro named `SIZE` = in the `lse.S` file. >>> Best regards, >>> Radek >>=20 >> Looks fine to me, but is __ELF__ correct? I am not familiar with = pseudo-ops, OK if it is ELF specific when PE is targeted. >>=20 >=20 > I suspect that, the end, we really need to generalize this so that = ELF, XCOFF, Mach-O etc. are handled. In other places in the tree, = typically an =E2=80=9Casm.h=E2=80=9D (or similar name) is included which = contains macros that adjust: >=20 > global symbol > local symbol > type > size >=20 > (and sometimes .cfi_xxxx-related) >=20 > Then the asm sources are adjusted to use those macros throughout, = which means that they build correctly for the different object file = formats. >=20 > You should be able to find a suitable example in other ports which = could be updated to cater for aarch64-specific cases. duh, I was not looking hard enough - it seems that there is already such = a file libgcc/config/aarch64/aarch64-asm.h=20 It has just not been used in the SME stuff. Iain