From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20886 invoked by alias); 19 May 2017 11:03:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20293 invoked by uid 89); 19 May 2017 11:03:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:209.85.161.193, H*RU:209.85.161.193 X-HELO: mail-yw0-f193.google.com Received: from mail-yw0-f193.google.com (HELO mail-yw0-f193.google.com) (209.85.161.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 May 2017 11:03:46 +0000 Received: by mail-yw0-f193.google.com with SMTP id h82so4672931ywb.3 for ; Fri, 19 May 2017 04:03:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J00wByU4i+uVAo8QFSMWR8t1jPEptFpho5DcVk7lz3s=; b=VVmG10vi2f8YTS/k28PMQgv1FIc+p20MTYoyhdU68vwEXqdCCnU5cDVIOuyhErl/ae lRL0QFXJDQ+0wztmOU0eQ0HQNWlRzR2wqGG/5qSPmzlFG1LmUXOCi0wKKFGraxprfy83 uToKblq/rrO8gLgx7xM/KgKmSZNnn1nKtv+pK3tpdcT2R5JJGI4H9z236csJDoa2KUzF +UigmWBJn4yEkWkfAfq1DtqgbgACrYtDiSzsJzlPV6XrwtLf2fu2YS60QEyQJz5O6UPo uSlc7qKcsfBEp2n4PuA+9fYGqCE/c5GJHW6b9ObbuZhdGy4PzU9louv3XlqXRGXB+V0j yZRw== X-Gm-Message-State: AODbwcAl4kXyG5Co4OWy0k45ZIjSEr5h2ucNMN2EJnbl007nplN3n+CD OT+d6poN9x9TtA== X-Received: by 10.129.147.134 with SMTP id k128mr7768600ywg.270.1495191828299; Fri, 19 May 2017 04:03:48 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a3:20fb:f6d0:5ac5:64cd:f102? ([2620:10d:c091:200::7:4a1a]) by smtp.googlemail.com with ESMTPSA id c198sm3608662ywh.79.2017.05.19.04.03.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2017 04:03:47 -0700 (PDT) Subject: Re: [PATCH] Try harder to fix recently introduced crashes in ggc_collect To: Richard Biener , Bernd Edlinger Cc: "gcc-patches@gcc.gnu.org" , Jakub Jelinek , Jeff Law , Jason Merrill References: <381BC021-5087-40F5-B517-8EB0239900B2@suse.de> From: Nathan Sidwell Message-ID: <25b2fbc3-5f96-146b-58e8-a226fe0e57ed@acm.org> Date: Fri, 19 May 2017 11:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg01550.txt.bz2 On 05/19/2017 03:51 AM, Richard Biener wrote: > you are commoning 'hwi' here. Also a bad (very short) name for a global > (even if static). > > I'll leave review to Nathan anyway. IMHO the C FE changes are obvious, with the fixing of the hwi name I guess. I'll go rename fn1..6 in the C++ FE once this lands. nathan -- Nathan Sidwell