From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 802913858D1E for ; Tue, 18 Apr 2023 18:43:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 802913858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-63b7096e2e4so1886739b3a.2 for ; Tue, 18 Apr 2023 11:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681843437; x=1684435437; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iHsLkmeK6DucIrL2pytaLNutQopSDG3IHAoWEzHlHGg=; b=Dtnn2ooHQXiw0fgkwnr1O6OQRK8NGZkdMW8nrFgzfcg1fROGJzN/kgmTYNXybSV+h2 9j2CAqbNnX/N8voGV7oyZvHckqcZW8afglXLK+iSIb3bEK26G1nQP6w9edu1xENKjO7t f9AR1uh8qTva8jbJmB4GhemwLi5ZToCDYqNjHCs7Ky98KRhCsrvBlXerp03TsYATu6oL fffQPh9oc4uYq6MHDV0zbGVUs17WXY6ayfrjevvj0TpqTSdwB8lev5EdAxeKKS+4VBba ePdGYo3umX4Ubnrpu1gEtwMnLBlJrl+mipfcnFUUszzRaBnb+6DZJ2TVTYMARy++zAkB 3x3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681843437; x=1684435437; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iHsLkmeK6DucIrL2pytaLNutQopSDG3IHAoWEzHlHGg=; b=OuulgVOCAiU86p43lrh1uxE4oyamLNnQxGLnztHDSHvgeSgTb5YfXX7z9CBqxoB7qk xNb0mQPlEi1CliOECRJaSH6iwv2oTbkZnqFAXmxQOQnIi8I3f8KmA6MXvLWLGugEKRxT BQeOTwcurgpEyY700lufAhMOfosQResEu6Wk3i4uKyxDMTgFHMi09dF2Y8l0ugN9cqT2 QXdwknSVDJyhPSDOctJXkdcB6QPshuLXDTafJFs+cYaJNapUqQYazLqtS3fQ5yrW2XHC qPmX8nTL/zgTOkjGlM9hKuA1lIkOAHUogFdh8r4QtBgQFVBuCJrkuLsZYTGtlQKJpLn2 ASlg== X-Gm-Message-State: AAQBX9dppHgtluEZ6A2FnGpC/FFzx2aC6XC1qSYm5yRT18DGWhlX/bj7 AgHgn1aPNdO72QLjKLDG/ww= X-Google-Smtp-Source: AKy350Y1XkxjZBChaxMr/Eu5up3fKISHfg647FmgJecpe90OWK90ZznlkgKgbplw7/0Do/fqC3gOpw== X-Received: by 2002:a05:6a00:2e0d:b0:63b:86a0:6a37 with SMTP id fc13-20020a056a002e0d00b0063b86a06a37mr672547pfb.34.1681843437162; Tue, 18 Apr 2023 11:43:57 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id v4-20020aa78084000000b0062e0c39977csm9616188pff.139.2023.04.18.11.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 11:43:56 -0700 (PDT) Message-ID: <25b39c5c-5a9c-b1c3-3f3d-82530afaa1f2@gmail.com> Date: Tue, 18 Apr 2023 12:43:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3] vect: Verify that GET_MODE_UNITS is greater than one for vect_grouped_store_supported Content-Language: en-US To: Kevin Lee , gcc-patches@gcc.gnu.org References: <20230417163856.2253309-1-kevinl@rivosinc.com> From: Jeff Law In-Reply-To: <20230417163856.2253309-1-kevinl@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/17/23 10:38, Kevin Lee wrote: > This patch properly guards gcc_assert (multiple_p (m_full_nelts, > m_npatterns)) in vec_perm_indices indices (sel, 2, nelt) for VNx1 vectors. > > Based on the feedback from Richard Biener and Richard Sandiford, > multiple_p has been used instead of maybe_lt to compare nelt with the > minimum size 2. > > Bootstrap and testing done on x86_64-pc-linux-gnu. Would this be ok for trunk? > > Patch V1: https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614463.html > Patch V2: https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614700.html > > Kevin Lee > gcc/ChangeLog: > > * tree-vect-data-refs.cc (vect_grouped_store_supported): Add new > condition. I fixed up the indentation and pushed this to the trunk. jeff