* [PATCH] s390: Fix expander popcountv8hi2_vx
@ 2023-10-16 11:20 Stefan Schulze Frielinghaus
2023-10-16 11:22 ` Andreas Krebbel
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Schulze Frielinghaus @ 2023-10-16 11:20 UTC (permalink / raw)
To: krebbel, gcc-patches; +Cc: Stefan Schulze Frielinghaus
The normal form of a CONST_INT which represents an integer of a mode
with fewer bits than in HOST_WIDE_INT is sign extended. This even holds
for unsigned integers.
This fixes an ICE during cse1 where we bail out at rtl.h:2297 since
INTVAL (x.first) == sext_hwi (INTVAL (x.first), precision) does not hold.
gcc/ChangeLog:
* config/s390/vector.md (popcountv8hi2_vx): Sign extend each
unsigned vector element.
---
gcc/config/s390/vector.md | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md
index f0e9ed3d263..7d1eb36e844 100644
--- a/gcc/config/s390/vector.md
+++ b/gcc/config/s390/vector.md
@@ -1154,14 +1154,14 @@
(plus:V16QI (match_dup 2) (match_dup 3)))
; Generate mask for the odd numbered byte elements
(set (match_dup 3)
- (const_vector:V16QI [(const_int 0) (const_int 255)
- (const_int 0) (const_int 255)
- (const_int 0) (const_int 255)
- (const_int 0) (const_int 255)
- (const_int 0) (const_int 255)
- (const_int 0) (const_int 255)
- (const_int 0) (const_int 255)
- (const_int 0) (const_int 255)]))
+ (const_vector:V16QI [(const_int 0) (const_int -1)
+ (const_int 0) (const_int -1)
+ (const_int 0) (const_int -1)
+ (const_int 0) (const_int -1)
+ (const_int 0) (const_int -1)
+ (const_int 0) (const_int -1)
+ (const_int 0) (const_int -1)
+ (const_int 0) (const_int -1)]))
; Zero out the even indexed bytes
(set (match_operand:V8HI 0 "register_operand" "=v")
(and:V8HI (subreg:V8HI (match_dup 2) 0)
--
2.41.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] s390: Fix expander popcountv8hi2_vx
2023-10-16 11:20 [PATCH] s390: Fix expander popcountv8hi2_vx Stefan Schulze Frielinghaus
@ 2023-10-16 11:22 ` Andreas Krebbel
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Krebbel @ 2023-10-16 11:22 UTC (permalink / raw)
To: Stefan Schulze Frielinghaus, gcc-patches
On 10/16/23 13:20, Stefan Schulze Frielinghaus wrote:
> The normal form of a CONST_INT which represents an integer of a mode
> with fewer bits than in HOST_WIDE_INT is sign extended. This even holds
> for unsigned integers.
>
> This fixes an ICE during cse1 where we bail out at rtl.h:2297 since
> INTVAL (x.first) == sext_hwi (INTVAL (x.first), precision) does not hold.
>
> gcc/ChangeLog:
>
> * config/s390/vector.md (popcountv8hi2_vx): Sign extend each
> unsigned vector element.
Ok. Thanks!
Bye,
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-16 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-16 11:20 [PATCH] s390: Fix expander popcountv8hi2_vx Stefan Schulze Frielinghaus
2023-10-16 11:22 ` Andreas Krebbel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).