public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Vladimir Makarov <vmakarov@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: patch to fix PR70703
Date: Fri, 07 Apr 2017 16:07:00 -0000	[thread overview]
Message-ID: <25d46ed9-dd7a-74bd-6ab3-91d581f85b4c@redhat.com> (raw)
In-Reply-To: <CAFiYyc293XK5geSy=43HOJdj4SOcom_f1C8-2ttacRmUb5hptQ@mail.gmail.com>



On 04/06/2017 06:24 AM, Richard Biener wrote:
> On Wed, Apr 5, 2017 at 6:18 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
>>
>> On 04/05/2017 12:07 PM, Vladimir Makarov wrote:
>>>
>>>
>>> I'll correct the patch.
>>>
>> Here is the patch I've committed.
> Note that in such contexts it's better to just use [u]int64_t.
>
>
You are right, Richard.  I've committed the following patch:

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 246764)
+++ ChangeLog   (working copy)
@@ -1,5 +1,11 @@
  2017-04-07  Vladimir Makarov  <vmakarov@redhat.com>

+       PR rtl-optimization/70703
+       * ira-color.c (update_conflict_hard_regno_costs): Use
+       int64_t instead of HOST_WIDE_INT.
+
+2017-04-07  Vladimir Makarov  <vmakarov@redhat.com>
+
         PR rtl-optimization/70478
         * lra-constraints.c (process_alt_operands): Disfavor alternative
         insn memory operands.
Index: ira-color.c
===================================================================
--- ira-color.c (revision 246763)
+++ ira-color.c (working copy)
@@ -1522,7 +1522,7 @@ update_conflict_hard_regno_costs (int *c
                 index = ira_class_hard_reg_index[aclass][hard_regno];
                 if (index < 0)
                   continue;
-               cost = (int) (((HOST_WIDE_INT) conflict_costs [i] * 
mult) / div);
+               cost = (int) (((int64_t) conflict_costs [i] * mult) / div);
                 if (cost == 0)
                   continue;
                 cont_p = true;

      reply	other threads:[~2017-04-07 16:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 15:11 Vladimir Makarov
2017-04-05 15:25 ` Jakub Jelinek
2017-04-05 16:07   ` Vladimir Makarov
2017-04-05 16:18     ` Vladimir Makarov
2017-04-06 10:24       ` Richard Biener
2017-04-07 16:07         ` Vladimir Makarov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25d46ed9-dd7a-74bd-6ab3-91d581f85b4c@redhat.com \
    --to=vmakarov@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).