From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7E8763858C98 for ; Wed, 17 Jan 2024 00:30:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E8763858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7E8763858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705451451; cv=none; b=GinSLEyv1KqUwarqbx2Ps1OhbvmOt0/1X3RyPTJakHvaMe3mnA7ksn51kBCtwupQzwdHjJ2jUl+z4lB3FFTbGqVzqU76Y3yXtTfZd2QDItNGnW8wmEVisTnEpErTpM8IBE5q6y3x0mMJEtfdTXetQBz3sgkJHxx4qnDu/4zqu/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705451451; c=relaxed/simple; bh=apGvCGgz0hkp4R4vjjfwhKDe+MJwqwue2pDmep5XH04=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EXPK/yGdut1pQq8u+bJOXDrGScl91FH0eJj+AzZ57P3UP3061NVE3cki4fpEexwnVK2UlQT7OtkKvf+UY3e/jEEllleQGogVs7SQ14IXYANceW5YJa/KIfyQ8gUxW7arBhscd26yCQhXLpQC4judiPCkC1DRRzMK6YHvA4WOMTc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705451450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ip8pDvvPFfSk5KKIEdZto/RZA3Q7J5y8WFmaScDxGhg=; b=CMLC6p0o+mfTvP9qpNuD59CqXEr9SNcW5+ebAXJs1KbOwjMG0JKsbFz/wv4c3yzEyc20Yf jh7DaSE7FHUQ6x7iTS0duMT08INAI+dMQUgCIORRl1nrhbeSkRt/jJee+X9KLwJldDFIlF Tk47wJxIvI3Z+Bi6yOjRhs1HQECeqy8= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-13-v7DnnXNpOHiY36hRn4h8xg-1; Tue, 16 Jan 2024 19:30:48 -0500 X-MC-Unique: v7DnnXNpOHiY36hRn4h8xg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-67f9895f046so156445176d6.1 for ; Tue, 16 Jan 2024 16:30:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705451448; x=1706056248; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ip8pDvvPFfSk5KKIEdZto/RZA3Q7J5y8WFmaScDxGhg=; b=idrr6zdtOZNfyPe3LwQUXjVlXFcSN7SxxyAX/+GP3mejDTFAvVH0iDu5M3ZPN3/UfK TBWFgUsGnkhPJ5cnD7QjfxWMU3zFS6nDElAhhbOpyf4BP38iso74ugcSXKoIxuPzYQ0/ Oa10Zh73k4jNnfzvlXnZqQjfFV6VafG4MNzzV4M+J/TdEXsjTcYIK2ZCrfZx/4lBKsSU OLpwVvik3gzecvqEpN2tT6bxgrGvHNLVNhZPwldIsDcFr9nCE1AZcKOvnNEBUH+s+KvY eG3jRwSfZ9DPvPcjy4l18n0S/NTtPyFxLHyW/LB6w+n9BWa+iIHyHdq/zS8iH25+e5TD Xt7g== X-Gm-Message-State: AOJu0Yx6mO2XiyTKN5cpRdpKyX+DetxavOOOIQNcY2f2whEl99dRBLqe yCrKwtJ0GoX7Ny0u0iHObuA/DMZSNPtgaxL4YUSvBMA9yfnOaWEitFdL8IueXZ66/rIsFFkYZQY 5prM9atEaW6krM6pr/osQJOlg6Q== X-Received: by 2002:ad4:5ae9:0:b0:681:42e1:f7ee with SMTP id c9-20020ad45ae9000000b0068142e1f7eemr9604321qvh.27.1705451447882; Tue, 16 Jan 2024 16:30:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEz8m2nTsKeGdskt5qb+v9867le7E060YXf6h4PmwljI0iHXEeBE8fQgmadqWWKdzC06Ob1/Q== X-Received: by 2002:ad4:5ae9:0:b0:681:42e1:f7ee with SMTP id c9-20020ad45ae9000000b0068142e1f7eemr9604304qvh.27.1705451447559; Tue, 16 Jan 2024 16:30:47 -0800 (PST) Received: from [192.168.1.146] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id l9-20020ad44d09000000b00680ca85b06fsm4612105qvl.31.2024.01.16.16.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 16:30:47 -0800 (PST) Message-ID: <25fff4d0-f560-4cb9-9180-6ec6620dfaa4@redhat.com> Date: Tue, 16 Jan 2024 19:30:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/14] c++: Implement __is_integral built-in trait To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, Ken Matsui , gcc-patches@gcc.gnu.org References: <20240110194031.2384005-1-kmatsui@gcc.gnu.org> <20240110194031.2384005-2-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240110194031.2384005-2-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/10/24 04:22, Ken Matsui wrote: > +/* Return true if T is an integral type. With __STRICT_ANSI__, __int128 and > + unsigned __int128 are not integral types. */ This really needs a rationale, since they are actually integer types. I know __int128 is considered an extension rather than an extended integer type under the standard, but is there a writeup we can point to for why? And even if we don't want to subject it to all the standard requirements of an extended integer type, why not still say it's an integral type? flag_iso is only supposed to disable features that could conflict with obscure but standard-conforming code, and since __int128 is in the reserved namespace, I'd think it should be safe to support (to the degree that we do) regardless of flag_iso. Jason