From: Jeff Law <law@redhat.com>
To: kugan <kugan.vivekanandarajah@linaro.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PR77719] Fix ICE in pp_string, at pretty-print.c:955
Date: Mon, 26 Sep 2016 15:46:00 -0000 [thread overview]
Message-ID: <26069b05-a8cd-a2e3-bf49-6ff5dfd7f53d@redhat.com> (raw)
In-Reply-To: <80a87b62-c193-2309-332d-22b1949d3e91@linaro.org>
On 09/25/2016 08:39 PM, kugan wrote:
>
>
> On 25/09/16 04:50, kugan wrote:
>> Hi,
>>
>> In make_new_ssa_for_def (tree-reassoc.c) we should use gimple_get_lhs to
>> get lhs instead of gimple_assign_lhs as stmt can be builtins too.
>> Attached patch fixes this.
>>
>> Testcase from PR (attached) seems to fail. I dont any fortran so I didnt
>> try fixing it. Any help here is appreciate. The log is:
>
> Here is a patch with the testcase based on the feedback from Joost
> VandeVondele and Dominique d'Humieres. Bootstrapped and regression
> tested on x86_64-linux-gnu with no new regressions.
>
> Is this OK for trunk?
>
> Thanks,
> kugan
>
> gcc/testsuite/ChangeLog:
>
> 2016-09-25 Kugan Vivekanandarajah <kuganv@linaro.org>
>
> * gfortran.dg/pr77719.f90: New test.
>
> gcc/ChangeLog:
>
> 2016-09-25 Kugan Vivekanandarajah <kuganv@linaro.org>
>
> * tree-ssa-reassoc.c (make_new_ssa_for_def): Use gimple_get_lhs to
> get lhs
> instead of gimple_assign_lhs as stmt can be builtins too.
>
OK.
jeff
next prev parent reply other threads:[~2016-09-26 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 7:07 kugan
2016-09-26 6:44 ` kugan
2016-09-26 15:46 ` Jeff Law [this message]
2016-09-25 7:46 Dominique d'Humières
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26069b05-a8cd-a2e3-bf49-6ff5dfd7f53d@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kugan.vivekanandarajah@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).