From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mengyan1223.wang (mengyan1223.wang [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 5262C3858D37 for ; Wed, 9 Mar 2022 10:58:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5262C3858D37 Received: from [IPv6:240e:358:1127:3f00:6aa7:515f:bf0f:665b] (unknown [IPv6:240e:358:1127:3f00:6aa7:515f:bf0f:665b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@mengyan1223.wang) by mengyan1223.wang (Postfix) with ESMTPSA id 6E6ED65BAC; Wed, 9 Mar 2022 05:57:57 -0500 (EST) Message-ID: <260c79313587c9f4f8f9fc83f384f7845af48090.camel@mengyan1223.wang> Subject: Re: [PATCH] vect: fix out-of-bound access in supports_vec_convert_optab_p [PR 104851] From: Xi Ruoyao To: Richard Biener Cc: GCC Patches , Richard Sandiford Date: Wed, 09 Mar 2022 18:57:51 +0800 In-Reply-To: References: <2a4f73f067275a669c841722d66b274768d21851.camel@mengyan1223.wang> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 10:58:04 -0000 On Wed, 2022-03-09 at 09:37 +0100, Richard Biener wrote: > On Wed, Mar 9, 2022 at 5:06 AM Xi Ruoyao via Gcc-patches > wrote: > > > > This should be obvious, OK for trunk? > > OK. Committed r12-7559. > > -- >8 -- > > > > Calling VECTOR_MODE_P with MAX_MACHINE_MODE has caused out-of-bound > > access. /* snip */ > > -  int end = mode == VOIDmode ? MAX_MACHINE_MODE : mode; > > +  int end = mode == VOIDmode ? MAX_MACHINE_MODE - 1 : mode; -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University