From: Eric Botcazou <ebotcazou@adacore.com>
To: gcc-patches@gcc.gnu.org
Subject: [patch] Fix PR C++/82872
Date: Thu, 21 Dec 2017 15:52:00 -0000 [thread overview]
Message-ID: <2618637.dVWshZqFx6@polaris> (raw)
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
Hi,
this is an ICE in the C++ FE on an offsetof construct with __PTRDIFF_MAX__ and
it happens only with this specific index:
In file included from pr82872.c:4:
pr82872.c: In function 'size_t foo()':
pr82872.c:10:10: internal compiler error: in ignore_overflows, at cp/cvt.c:583
return offsetof (struct S, a[__PTRDIFF_MAX__]);
^~~~~~~~
0x65ef7f ignore_overflows
/home/eric/svn/gcc/gcc/cp/cvt.c:583
0x661bcc ocp_convert(tree_node*, tree_node*, int, int, int)
/home/eric/svn/gcc/gcc/cp/cvt.c:817
0x6636e0 convert(tree_node*, tree_node*)
/home/eric/svn/gcc/gcc/cp/cvt.c:1580
0x882b62 fold_offsetof(tree_node*)
/home/eric/svn/gcc/gcc/c-family/c-common.c:6282
0x801c0c finish_offsetof(tree_node*, tree_node*, unsigned int)
/home/eric/svn/gcc/gcc/cp/semantics.c:4041
0x74596b cp_parser_builtin_offsetof
/home/eric/svn/gcc/gcc/cp/parser.c:9828
The C++ FE is quite picky about constant integer overflow during conversion
operations and checks that they can only _introduce_ overflows and never make
them disappear, the latter case occuring here in convert_to_integer_1.
Tested on x86_64-suse-linux, OK for the mainline?
2017-12-21 Eric Botcazou <ebotcazou@adacore.com>
PR C++/82872
* convert.c (convert_to_integer_1) <POINTER_TYPE>: Do not return
the shared zero if the input has overflowed.
2017-12-21 Eric Botcazou <ebotcazou@adacore.com>
* c-c++-common/pr82872.c: New test.
--
Eric Botcazou
[-- Attachment #2: pr82872.c --]
[-- Type: text/x-csrc, Size: 165 bytes --]
/* PR c++/82872 */
/* { dg-do compile } */
#include <stddef.h>
struct S { int i, a[1]; };
size_t foo (void)
{
return offsetof (struct S, a[__PTRDIFF_MAX__]);
}
[-- Attachment #3: pr82872.diff --]
[-- Type: text/x-patch, Size: 469 bytes --]
Index: convert.c
===================================================================
--- convert.c (revision 255850)
+++ convert.c (working copy)
@@ -671,7 +671,7 @@ convert_to_integer_1 (tree type, tree ex
{
case POINTER_TYPE:
case REFERENCE_TYPE:
- if (integer_zerop (expr))
+ if (integer_zerop (expr) && !TREE_OVERFLOW (expr))
return build_int_cst (type, 0);
/* Convert to an unsigned integer of the correct width first, and from
next reply other threads:[~2017-12-21 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 15:52 Eric Botcazou [this message]
2017-12-21 15:53 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2618637.dVWshZqFx6@polaris \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).