From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 518 invoked by alias); 26 Apr 2016 21:02:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 130414 invoked by uid 89); 26 Apr 2016 21:02:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 26 Apr 2016 21:02:22 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 15E89C057FA6; Tue, 26 Apr 2016 21:02:20 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-93.phx2.redhat.com [10.3.113.93]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3QL2I4B029512; Tue, 26 Apr 2016 17:02:19 -0400 Subject: Re: Combine simplify_set WORD_REGISTER_OPERATIONS To: Alan Modra , gcc-patches@gcc.gnu.org References: <20160131221641.GV17028@bubble.grove.modra.org> Cc: Segher Boessenkool From: Jeff Law Message-ID: <2618e846-3458-7f19-d235-67b87c7461c9@redhat.com> Date: Tue, 26 Apr 2016 21:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160131221641.GV17028@bubble.grove.modra.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg01554.txt.bz2 On 01/31/2016 03:16 PM, Alan Modra wrote: > The comment says this test is supposed to prevent "a narrower > operation than requested", but it actually only allows a larger > subreg, not one the same size. Fix that. > > Bootstrapped and regression tested powerpc64-linux. OK for stage1? > > Note that this bug was found when investigating why gcc-6 does not > suffer from pr69548, ie. this bug was masking a powerpc backend bug. > > * combine.c (simplify_set): Correct WORD_REGISTER_OPERATIONS test. This is fine. Please install. THanks, Jeff