public inbox for
 help / color / mirror / Atom feed
From: Jason Merrill <>
To: Patrick Palka <>
Subject: Re: [PATCH] c++: redundant targ coercion for var/alias tmpls
Date: Wed, 28 Jun 2023 11:50:09 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <dda6359b-ce5a-e50f-3399-89d2fab7837f@idea>

On 6/23/23 12:23, Patrick Palka wrote:
> On Fri, 23 Jun 2023, Jason Merrill wrote:
>> On 6/21/23 13:19, Patrick Palka wrote:
>>> When stepping through the variable/alias template specialization code
>>> paths, I noticed we perform template argument coercion twice: first from
>>> instantiate_alias_template / finish_template_variable and again from
>>> tsubst_decl (during instantiate_template).  It should suffice to perform
>>> coercion once.
>>> To that end patch elides this second coercion from tsubst_decl when
>>> possible.  We can't get rid of it completely because we don't always
>>> specialize a variable template from finish_template_variable: we could
>>> also be doing so directly from instantiate_template during variable
>>> template partial specialization selection, in which case the coercion
>>> from tsubst_decl would be the first and only coercion.
>> Perhaps we should be coercing in lookup_template_variable rather than
>> finish_template_variable?
> Ah yes, there's a patch for that at
> :)

So after that patch, can we get rid of the second coercion completely?


  reply	other threads:[~2023-06-28 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 17:19 Patrick Palka
2023-06-23 15:11 ` Jason Merrill
2023-06-23 16:23   ` Patrick Palka
2023-06-28 15:50     ` Jason Merrill [this message]
2023-06-28 20:14       ` Patrick Palka
2023-07-13 15:48         ` Patrick Palka
2023-07-13 20:44           ` Jason Merrill
2023-07-14 18:07             ` Patrick Palka
2023-07-14 21:17               ` Jason Merrill
2023-07-17 21:29                 ` Patrick Palka
2023-07-18 16:52                   ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).